Bug 64083 - (fatal) build warning on 32-bit
Summary: (fatal) build warning on 32-bit
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-04-30 11:52 UTC by Simon McVittie
Modified: 2013-04-30 12:14 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
tests: avoid an out-of-range int literal (1.06 KB, patch)
2013-04-30 11:52 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-04-30 11:52:15 UTC
Created attachment 78646 [details] [review]
tests: avoid an out-of-range int literal

In this particular test case, the expected result according to the flags
is "it fails", so the second column (expected converted value) is not
relevant.

This apparently causes build warnings (fatal by default) on ILP32
platforms, because 2147483648 is out-of-range for a signed int or
signed long on such platforms. It's certainly also out-of-range for
the struct member it's initializing, which is a gint32.
Comment 1 Guillaume Desmottes 2013-04-30 11:54:29 UTC
Comment on attachment 78646 [details] [review]
tests: avoid an out-of-range int literal

Review of attachment 78646 [details] [review]:
-----------------------------------------------------------------

++
Comment 2 Simon McVittie 2013-04-30 12:14:39 UTC
Fixed in git for 5.15.0, thanks. (The test is new in master, so no need to fix in 5.14.)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.