Attachment 86177 Details for Bug 69600 – [MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions

[patch] [MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions

0001-Update-extension-interfaces-to-their-telepathy-spec-.patch (text/plain), 8.75 KB, created by Simon McVittie on 2013-09-20 12:36:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-20 12:36:59 UTC

Size: 8.75 KB

patch

obsolete

>From 9fa3c65e038f66dcf4c28bd10a26680229c2843c Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 20 Sep 2013 12:59:50 +0100
>Subject: [PATCH] Update extension interfaces to their telepathy-spec 0.27.1
> versions
>
>No functional changes.
>
>The remaining interfaces (A.I.Conditions, CD.I.Messages) are still
>not in telepathy-spec at all. :-(
>---
> ...Account_Interface_External_Password_Storage.xml | 20 +++++++++-----
> xml/Account_Interface_Hidden.xml | 25 ++++++++++++++---
> xml/Account_Manager_Interface_Hidden.xml | 3 +--
> ...onnection_Manager_Interface_Account_Storage.xml | 31 ++++++++++++----------
> 4 files changed, 53 insertions(+), 26 deletions(-)
>
>diff --git a/xml/Account_Interface_External_Password_Storage.xml b/xml/Account_Interface_External_Password_Storage.xml
>index f868f65..5bd1bfc 100644
>--- a/xml/Account_Interface_External_Password_Storage.xml
>+++ b/xml/Account_Interface_External_Password_Storage.xml
>@@ -22,29 +22,35 @@
> 
> <interface name="org.freedesktop.Telepathy.Account.Interface.ExternalPasswordStorage.DRAFT"
> tp:causes-havoc="experimental">
>- <tp:added version="0.21.UNRELEASED">(draft 1)</tp:added>
>+ <tp:added version="0.21.10">(draft 1)</tp:added>
> <tp:requires interface="org.freedesktop.Telepathy.Account"/>
> 
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> An interface for Accounts whose passwords are stored externally and
>- SHOULD NOT be stored by either the <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy">AccountManager</tp:dbus-ref> nor
>- any <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy.Channel.Type">ServerAuthentication</tp:dbus-ref>
>+ SHOULD NOT be stored by either the
>+ <tp:dbus-ref namespace="ofdT">AccountManager</tp:dbus-ref> nor any
>+ <tp:dbus-ref namespace="ofdT.Channel.Type">ServerAuthentication</tp:dbus-ref>
> handler.
>+
>+ This interface SHOULD only appear on accounts for which the
>+ related Connection Manager implements
>+ <tp:dbus-ref namespace="ofdT">ConnectionManager.Interface.AccountStorage.DRAFT</tp:dbus-ref>.
> </tp:docstring>
> 
> <method name="ForgetPassword" tp:name-for-bindings="Forget_Password">
> <tp:docstring>
>- Clears any saved password associated with this account.
>+ Clears any saved password associated with this account.
> </tp:docstring>
> </method>
> 
> <property name="PasswordSaved"
> tp:name-for-bindings="Password_Saved"
> type="b" access="read">
>- <tp:docstring>
>+ <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> Indicates whether the account has a saved password or not.
>+
>+ Change notification for this property is provided by the
>+ standard D-Bus <code>PropertiesChanged</code> signal.
> </tp:docstring>
> </property>
> 
>diff --git a/xml/Account_Interface_Hidden.xml b/xml/Account_Interface_Hidden.xml
>index 5457733..cb00191 100644
>--- a/xml/Account_Interface_Hidden.xml
>+++ b/xml/Account_Interface_Hidden.xml
>@@ -22,11 +22,30 @@
> 
> <interface name="org.freedesktop.Telepathy.Account.Interface.Hidden.DRAFT1"
> tp:causes-havoc="outrageous">
>- <tp:added version="0.21.UNRELEASED">(draft 1)</tp:added>
>+ <tp:added version="0.21.10">(draft 1)</tp:added>
> 
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>- 
>- 
>+ An interface for flagging certain accounts as hidden, so that they do
>+ not appear in the account manager's standard lists of accounts.
>+ Accounts whose <tp:member-ref>Hidden</tp:member-ref> property is
>+ <code>True</code> are intended for non-interactive use (by
>+ non-user-visible services), and appear on the <tp:dbus-ref
>+ namespace='ofdT'>AccountManager.Interface.Hidden.DRAFT1</tp:dbus-ref>
>+ interface; in all other respects, they behave like any other
>+ account.
>+
>+ <tp:rationale>
>+ XMPP, in particular, is increasingly used for purposes other than
>+ instant messaging and VoIP. For instance, extensions exist for
>+ inter-device bookmark synchronization.
>+
>+ While obviously these services could re-use connections intended for
>+ instant messaging, in some cases you might want to use a different
>+ account. (Perhaps your bookmark sync provider is not your IM
>+ provider.) This API allows such auxiliary accounts to exist in
>+ Telepathy, while not being displayed in standard user interfaces for
>+ IM, VoIP, and friends.
>+ </tp:rationale>
> </tp:docstring>
> 
> <property name="Hidden" tp:name-for-bindings="Hidden"
>diff --git a/xml/Account_Manager_Interface_Hidden.xml b/xml/Account_Manager_Interface_Hidden.xml
>index 46c6d32..284eb64 100644
>--- a/xml/Account_Manager_Interface_Hidden.xml
>+++ b/xml/Account_Manager_Interface_Hidden.xml
>@@ -28,7 +28,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> namespace='ofdT.Account.Interface.Hidden.DRAFT1'>Hidden</tp:dbus-ref>
> property is <code>True</code>.
> </tp:docstring>
>- <tp:added version="0.21.UNRELEASED">first draft</tp:added>
>+ <tp:added version="0.21.10">first draft</tp:added>
> 
> <property name="ValidHiddenAccounts" type="ao" access="read"
> tp:name-for-bindings="Valid_Hidden_Accounts">
>@@ -98,4 +98,3 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> </interface>
> </node>
> 
>-
>diff --git a/xml/Connection_Manager_Interface_Account_Storage.xml b/xml/Connection_Manager_Interface_Account_Storage.xml
>index 5c7dd03..2f4f4bf 100644
>--- a/xml/Connection_Manager_Interface_Account_Storage.xml
>+++ b/xml/Connection_Manager_Interface_Account_Storage.xml
>@@ -22,25 +22,25 @@
> 
> <interface name="org.freedesktop.Telepathy.ConnectionManager.Interface.AccountStorage.DRAFT"
> tp:causes-havoc="experimental">
>- <tp:added version="0.21.UNRELEASED">(draft 1)</tp:added>
>+ <tp:added version="0.21.10">(draft 1)</tp:added>
> <tp:requires interface="org.freedesktop.Telepathy.ConnectionManager"/>
> 
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> An interface for connection managers that store account details
> internally. At the moment this consists only of storing an account's
> credentials, but other functionality may be added in the future.
>- <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy">Account</tp:dbus-ref> objects
>+
>+ <tp:dbus-ref namespace="ofdT">Account</tp:dbus-ref> objects
> representing accounts on a connection manager that implements this
>- interface should implement the <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy.Account.Interface">ExternalPasswordStorage.DRAFT</tp:dbus-ref>
>+ interface should implement the
>+	<tp:dbus-ref namespace="ofdT.Account.Interface">ExternalPasswordStorage.DRAFT</tp:dbus-ref>
> interface.
>-
> </tp:docstring>
> 
> <tp:flags name="Account_Flags" value-prefix="Account_Flag" type="u">
> <tp:docstring>
>- A set of flags representing the status of the Account stored in the Connection Manager.
>+ A set of flags representing the status of the Account stored in the
>+ Connection Manager.
> </tp:docstring>
> 
> <tp:flag suffix="Credentials_Stored" value="1">
>@@ -61,9 +61,12 @@
> <property name="Accounts"
> tp:name-for-bindings="Accounts"
> type="a{su}" tp:type="Account_Flags_Map" access="read">
>- <tp:docstring>
>- The set of Accounts stored in this connection manager, and flags
>- indicating their status.
>+ <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>+ The set of Accounts stored in this Connection Manager, and flags
>+ indicating their status.
>+
>+ Change notification for this property is provided by the standard
>+ D-Bus <code>PropertiesChanged</code> signal.
> </tp:docstring>
> </property>
> 
>@@ -76,8 +79,8 @@
> <arg direction="in" name="Account_Id"
> type="s">
> <tp:docstring>
>- An account id as returned from <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy">Protocol.IdentifyAccount</tp:dbus-ref>.
>+ An account id as returned from
>+	 <tp:dbus-ref namespace="ofdT">Protocol.IdentifyAccount</tp:dbus-ref>.
> </tp:docstring>
> </arg>
> 
>@@ -99,8 +102,8 @@
> <arg direction="in" name="Account_Id"
> type="s">
> <tp:docstring>
>- An account id as returned from <tp:dbus-ref
>- namespace="org.freedesktop.Telepathy">Protocol.IdentifyAccount</tp:dbus-ref>.
>+ An account id as returned from
>+	 <tp:dbus-ref namespace="ofdT">Protocol.IdentifyAccount</tp:dbus-ref>.
> </tp:docstring>
> </arg>
> 
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 69600: 86177 | 87472 | 93056 | 93057

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.