Bug 69600 - MC: do something about extension interfaces
Summary: MC: do something about extension interfaces
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard: review?
Keywords: patch
Depends on: 33101 37380 69446
Blocks: 70382 71093
  Show dependency treegraph
 
Reported: 2013-09-20 12:05 UTC by Simon McVittie
Modified: 2014-02-03 18:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
[MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions (8.75 KB, patch)
2013-09-20 12:36 UTC, Simon McVittie
Details | Splinter Review
[MC master] Remove Conditions interface (24.06 KB, patch)
2013-10-11 16:18 UTC, Simon McVittie
Details | Splinter Review
Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage (25.17 KB, patch)
2014-01-30 13:33 UTC, Simon McVittie
Details | Splinter Review
Remove code-generation machinery (244.58 KB, patch)
2014-01-30 13:34 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-09-20 12:05:02 UTC
Mission Control has a bunch of bonus interfaces. Each of them should either be part of telepathy-spec, or not exist.

A good starting point would be "sync them with the corresponding draft in telepathy-spec"...
Comment 1 Simon McVittie 2013-09-20 12:36:59 UTC
Created attachment 86177 [details] [review]
[MC master] Update extension interfaces to their telepathy-spec 0.27.1  versions

No functional changes.

The remaining interfaces (A.I.Conditions, CD.I.Messages) are still
not in telepathy-spec at all. :-(
Comment 2 Simon McVittie 2013-09-20 12:39:58 UTC
A.I.Hidden, AM.I.Hidden: Bug #33101
CD.I.Messages: Bug #37380
A.I.ExternalPasswordStorage, CM.I.AccountStorage: Bug #33485 (but should be undrafted, unless we're just going to delete it)
A.I.Conditions: Bug #24896
Comment 3 Simon McVittie 2013-10-11 16:17:33 UTC
Comment on attachment 86177 [details] [review]
[MC master] Update extension interfaces to their telepathy-spec 0.27.1  versions

I merged this.
Comment 4 Simon McVittie 2013-10-11 16:18:28 UTC
Created attachment 87472 [details] [review]
[MC master] Remove Conditions interface

I was never sure about the design, and the supporting code was removed
when I refactored connectivity for 5.16. If it's needed in future,
we can bring it back, hopefully with a simpler design.

---

Bringing it back is Bug #24896, which already has a simpler design (that was never implemented).
Comment 5 Guillaume Desmottes 2013-10-11 21:34:54 UTC
Comment on attachment 87472 [details] [review]
[MC master] Remove Conditions interface

Review of attachment 87472 [details] [review]:
-----------------------------------------------------------------

++
Comment 6 Simon McVittie 2013-10-14 17:05:30 UTC
Comment on attachment 87472 [details] [review]
[MC master] Remove Conditions interface

Deleted for 5.17.
Comment 7 Simon McVittie 2014-01-30 13:31:50 UTC
Please review this first: https://bugs.freedesktop.org/show_bug.cgi?id=69446#c3
Comment 9 Simon McVittie 2014-01-30 13:34:34 UTC
Created attachment 93057 [details] [review]
Remove code-generation machinery

---

This seems as good a way as any to assert that we don't have any extension interfaces :-P
Comment 10 Guillaume Desmottes 2014-02-03 11:25:03 UTC
Comment on attachment 93056 [details] [review]
Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage

Review of attachment 93056 [details] [review]:
-----------------------------------------------------------------

++
Comment 11 Guillaume Desmottes 2014-02-03 11:25:24 UTC
Comment on attachment 93057 [details] [review]
Remove code-generation machinery

Review of attachment 93057 [details] [review]:
-----------------------------------------------------------------

++
Comment 12 Simon McVittie 2014-02-03 18:15:05 UTC
No more extension interfaces! Fixed in git for 5.17.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.