Attachment 88291 Details for Bug 71001 – mctest: fix invalid method implementations

[patch] mctest: fix invalid method implementations

0001-mctest-fix-invalid-method-implementations.patch (text/plain), 1.64 KB, created by Simon McVittie on 2013-10-29 14:16:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-10-29 14:16:31 UTC

Size: 1.64 KB

patch

obsolete

>From ecd27dae0a48baf0246eb3734903c13cf449fb47 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 29 Oct 2013 13:37:11 +0000
>Subject: [PATCH 01/12] mctest: fix invalid method implementations
>
>There's no variable called s - I wanted a string "s". The relevant test,
>account-manager/param-types.py, only failed intermittently, because
>it's a matter of timing whether telepathy-glib loads the .manager file
>or introspects the ConnectionManager.
>---
> tests/twisted/mctest.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tests/twisted/mctest.py b/tests/twisted/mctest.py
>index debc6f4..b093ee8 100644
>--- a/tests/twisted/mctest.py
>+++ b/tests/twisted/mctest.py
>@@ -1090,7 +1090,7 @@ class SimulatedConnectionManager(object):
>                     ('i', 0, 'i', dbus.Int32(0)),
>                     ('x', 0, 'x', dbus.Int64(0)),
>                     ('d', 0, 'd', 0.0),
>-                    ('as', 0, 'as', dbus.Array(signature=s)),
>+                    ('as', 0, 'as', dbus.Array(signature='s')),
>                     ('y', 0, 'y', dbus.Byte(0)),
>                     ], signature='(susv)')
> 
>@@ -1107,7 +1107,7 @@ class SimulatedConnectionManager(object):
>                     ('x', cs.PARAM_HAS_DEFAULT, 'x', dbus.Int64(-1)),
>                     ('d', cs.PARAM_HAS_DEFAULT, 'd', 1.5),
>                     ('as', cs.PARAM_HAS_DEFAULT, 'as',
>-                        dbus.Array(['foo', 'bar', 'baz'], signature=s)),
>+                        dbus.Array(['foo', 'bar', 'baz'], signature='s')),
>                     ('y', cs.PARAM_HAS_DEFAULT, 'y', dbus.Byte(1)),
>                     ], signature='(susv)')
> 
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 71001: 88291 | 88292

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.