Bug 71001 - some intermittent MC test failures
Summary: some intermittent MC test failures
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-10-29 14:16 UTC by Simon McVittie
Modified: 2013-10-29 16:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
mctest: fix invalid method implementations (1.64 KB, patch)
2013-10-29 14:16 UTC, Simon McVittie
Details | Splinter Review
account-manager/avatar.py: fix race condition by combining expect_many calls (1.46 KB, patch)
2013-10-29 14:19 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-10-29 14:16:11 UTC
See patches.
Comment 1 Simon McVittie 2013-10-29 14:16:31 UTC
Created attachment 88291 [details] [review]
mctest: fix invalid method implementations

There's no variable called s - I wanted a string "s". The relevant test,
account-manager/param-types.py, only failed intermittently, because
it's a matter of timing whether telepathy-glib loads the .manager file
or introspects the ConnectionManager.
Comment 2 Simon McVittie 2013-10-29 14:19:04 UTC
Created attachment 88292 [details] [review]
account-manager/avatar.py: fix race condition by  combining expect_many calls

The test account-storage plugin uses GDBus, so its signals have an
undefined order with respect to MC's dbus-glib signals. We don't
actually care about the order anyway, so expect them all in one
big expect_many call.
Comment 3 Guillaume Desmottes 2013-10-29 14:32:21 UTC
Comment on attachment 88291 [details] [review]
mctest: fix invalid method implementations

Review of attachment 88291 [details] [review]:
-----------------------------------------------------------------

++
Comment 4 Guillaume Desmottes 2013-10-29 14:32:48 UTC
Comment on attachment 88292 [details] [review]
account-manager/avatar.py: fix race condition by  combining expect_many calls

Review of attachment 88292 [details] [review]:
-----------------------------------------------------------------

++
Comment 5 Simon McVittie 2013-10-29 16:15:44 UTC
Fixed in git for 5.17.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.