Attachment 97762 Details for Bug 76711 – [PATCH 1/2] drm/i915: clean up VBT eDP link param decoding

[patch] [PATCH 1/2] drm/i915: clean up VBT eDP link param decoding

0001-drm-i915-clean-up-VBT-eDP-link-param-decoding.patch (text/plain), 2.98 KB, created by Jani Nikula on 2014-04-22 17:20:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-04-22 17:20:04 UTC

Size: 2.98 KB

patch

obsolete

>From 17a35fa04a0af7454d3f9370153ab7701a1622c7 Mon Sep 17 00:00:00 2001
>Message-Id: <17a35fa04a0af7454d3f9370153ab7701a1622c7.1398186862.git.jani.nikula@intel.com>
>In-Reply-To: <cover.1398186862.git.jani.nikula@intel.com>
>References: <cover.1398186862.git.jani.nikula@intel.com>
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Tue, 22 Apr 2014 19:19:50 +0300
>Subject: [PATCH 1/2] drm/i915: clean up VBT eDP link param decoding
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_bios.c | 52 ++++++++++++++++++++++++++++-----------
> 1 file changed, 38 insertions(+), 14 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>index fba9efd09e87..87a1fa6485be 100644
>--- a/drivers/gpu/drm/i915/intel_bios.c
>+++ b/drivers/gpu/drm/i915/intel_bios.c
>@@ -592,47 +592,71 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
> 
> 	dev_priv->vbt.edp_pps = *edp_pps;
> 
>-	dev_priv->vbt.edp_rate = edp_link_params->rate ? DP_LINK_BW_2_7 :
>-		DP_LINK_BW_1_62;
>+	switch (edp_link_params->rate) {
>+	case EDP_RATE_1_62:
>+		dev_priv->vbt.edp_rate = DP_LINK_BW_1_62;
>+		break;
>+	case EDP_RATE_2_7:
>+		dev_priv->vbt.edp_rate = DP_LINK_BW_2_7;
>+		break;
>+	default:
>+		DRM_DEBUG_KMS("VBT has unknown eDP link rate value %u\n",
>+			      edp_link_params->rate);
>+		break;
>+	}
>+
> 	switch (edp_link_params->lanes) {
>-	case 0:
>+	case EDP_LANE_1:
> 		dev_priv->vbt.edp_lanes = 1;
> 		break;
>-	case 1:
>+	case EDP_LANE_2:
> 		dev_priv->vbt.edp_lanes = 2;
> 		break;
>-	case 3:
>-	default:
>+	case EDP_LANE_4:
> 		dev_priv->vbt.edp_lanes = 4;
> 		break;
>+	default:
>+		DRM_DEBUG_KMS("VBT has unknown eDP lane count value %u\n",
>+			      edp_link_params->lanes);
>+		break;
> 	}
>+
> 	switch (edp_link_params->preemphasis) {
>-	case 0:
>+	case EDP_PREEMPHASIS_NONE:
> 		dev_priv->vbt.edp_preemphasis = DP_TRAIN_PRE_EMPHASIS_0;
> 		break;
>-	case 1:
>+	case EDP_PREEMPHASIS_3_5dB:
> 		dev_priv->vbt.edp_preemphasis = DP_TRAIN_PRE_EMPHASIS_3_5;
> 		break;
>-	case 2:
>+	case EDP_PREEMPHASIS_6dB:
> 		dev_priv->vbt.edp_preemphasis = DP_TRAIN_PRE_EMPHASIS_6;
> 		break;
>-	case 3:
>+	case EDP_PREEMPHASIS_9_5dB:
> 		dev_priv->vbt.edp_preemphasis = DP_TRAIN_PRE_EMPHASIS_9_5;
> 		break;
>+	default:
>+		DRM_DEBUG_KMS("VBT has unknown eDP pre-emphasis value %u\n",
>+			      edp_link_params->preemphasis);
>+		break;
> 	}
>+
> 	switch (edp_link_params->vswing) {
>-	case 0:
>+	case EDP_VSWING_0_4V:
> 		dev_priv->vbt.edp_vswing = DP_TRAIN_VOLTAGE_SWING_400;
> 		break;
>-	case 1:
>+	case EDP_VSWING_0_6V:
> 		dev_priv->vbt.edp_vswing = DP_TRAIN_VOLTAGE_SWING_600;
> 		break;
>-	case 2:
>+	case EDP_VSWING_0_8V:
> 		dev_priv->vbt.edp_vswing = DP_TRAIN_VOLTAGE_SWING_800;
> 		break;
>-	case 3:
>+	case EDP_VSWING_1_2V:
> 		dev_priv->vbt.edp_vswing = DP_TRAIN_VOLTAGE_SWING_1200;
> 		break;
>+	default:
>+		DRM_DEBUG_KMS("VBT has unknown eDP voltage swing value %u\n",
>+			      edp_link_params->vswing);
>+		break;
> 	}
> }
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 76711: 96497 | 96498 | 96499 | 96741 | 97114 | 97762 | 97763 | 97795 | 97934 | 97936 | 98112 | 98590 | 98651 | 98652 | 98718 | 98719 | 98720 | 98721 | 98722 | 98723

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.