Bug 10171

Summary: build system fix when source is in cvs or svn
Product: dbus Reporter: Ralf Habacker <ralf.habacker>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch for build system
updated patch

Description Ralf Habacker 2007-03-03 03:50:30 UTC
When running dbus test suite using cvs or svn dbus source, cvs/svn control files are used accidently as test input. Tthe appended patch fixes it.
Comment 1 Ralf Habacker 2007-03-03 03:51:11 UTC
Created attachment 8960 [details] [review]
patch for build system
Comment 2 Havoc Pennington 2007-03-03 09:05:25 UTC
there are multiple uses of FIND_TESTS in the file, the patch probably needs to cover all of them, right?

I wonder if there is a way to do this by changing the arguments to the find, instead of using grep
Comment 3 Ralf Habacker 2007-03-03 09:40:44 UTC
(In reply to comment #2)
> there are multiple uses of FIND_TESTS in the file, the patch probably needs to
> cover all of them, right?

I will update this patch to catch every place. 
 
> I wonder if there is a way to do this by changing the arguments to the find,
> instead of using grep

Sure it may be better, but I personally haven't found a working solution using the find command because it is very tricky to exclude these path especially because in some places the find command is continued 

line107:	FILES=`(cd $(srcdir) && $(FIND_TESTS) -o -name "*.in" -a -not -name Makefile.in)` ;					\




Comment 4 Ralf Habacker 2007-03-03 09:41:16 UTC
Created attachment 8962 [details] [review]
updated patch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.