|Summary:||file INSTALL breaks make install on cygwin|
|Product:||xorg||Reporter:||Alexander Gottwald <ago>|
|Component:||Lib/other||Assignee:||Xorg Project Team <xorg-team>|
|Status:||RESOLVED FIXED||QA Contact:|
|i915 platform:||i915 features:|
|Bug Depends on:|
Description Alexander Gottwald 2004-08-11 12:39:49 UTC
because cygwin is not case sensitive the file INSTALL in lib/Xdamage, lib/Xfixes and lib/Xcomposite will prevent make from properly installing Xdamage.h, Xcomposite.h and Xfixes.h Solution is adding .PHONY: install to the makefiles if all supported make variants understand it or removing the INSTALL files from cvs
Comment 1 Alexander Gottwald 2004-08-11 13:00:28 UTC
Created attachment 610 [details] [review] proposed patch adds .PHONY: install to imake.tmpl i'm not sure if all supported make variants understand that
Comment 2 Kristian Høgsberg 2004-08-11 13:31:54 UTC
Wouldn't "any" make that you could use on cygwin support .phony? Cygwin gives you GNU make, so wouldn't #ifdef CYGWIN .phony install #endif be acceptable (if not exactly elegant...)?
Comment 3 Alexander Gottwald 2004-08-12 01:33:47 UTC
Created attachment 616 [details] [review] revised patch. .PHONY: install is wrapped with #ifdef cygwinArchitecture
Comment 4 Kristian Høgsberg 2004-08-13 07:18:54 UTC
Created attachment 625 [details] [review] Patch to add .PHONY target when using GNU make This would belong in Imake.rules, I think. I changed the patch to always use phony targets when using GNU make, since it also speeds up make in general. Also, I added a list of other targets and a little essay about the .PHONY target.
Comment 5 Kristian Høgsberg 2004-08-13 10:29:00 UTC
Patch applied, bug closed.
Comment 6 Kristian Høgsberg 2004-08-13 10:40:35 UTC