| Summary: | NULL pointer access crash on Sacha Willems' Vulkan raytracing demo after "spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory" | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Eero Tamminen <eero.t.tamminen> |
| Component: | Drivers/DRI/i965 | Assignee: | Jason Ekstrand <jason> |
| Status: | VERIFIED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=104213 https://github.com/SaschaWillems/Vulkan/issues/345 https://bugs.freedesktop.org/show_bug.cgi?id=99507 |
||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | attachment-4956-0.html | ||
|
Description
Eero Tamminen
2017-12-19 15:21:09 UTC
(In reply to Eero Tamminen from comment #0) > Does this check need also relaxing? The reason why ask about this is because of this comment: "we've seen glslang (even the latest from master) generating invalid SPIR-V code for your Raytracing demo, it gets a type conversion wrong on the Sphere type" in the Raytracing demo bug: https://github.com/SaschaWillems/Vulkan/issues/345 Created attachment 136494 [details] attachment-4956-0.html Yeah, I've run into similar issues with DOOM. I sent a patch last night which should help with it. I'm actually planning to revamp it a bit and resend. On January 2, 2018 05:09:25 bugzilla-daemon@freedesktop.org wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=104338 > > --- Comment #1 from Eero Tamminen <eero.t.tamminen@intel.com> --- > (In reply to Eero Tamminen from comment #0) >> Does this check need also relaxing? > > The reason why ask about this is because of this comment: > "we've seen glslang (even the latest from master) generating invalid SPIR-V > code for your Raytracing demo, it gets a type conversion wrong on the Sphere > type" > > in the Raytracing demo bug: > https://github.com/SaschaWillems/Vulkan/issues/345 > > -- > You are receiving this mail because: > You are the assignee for the bug. This should be fixed by the following commit: commit 154668e79c4556ba0eda4751d6a14a45b9242a90 Author: Jason Ekstrand <jason.ekstrand@intel.com> Date: Mon Jan 1 20:00:02 2018 -0800 spirv: Loosen the validation for load/store type matching Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104338 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104424 Tested-by: Eero Tamminen <eero.t.tamminen@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Verified. Raytracing demo works fine with Mesa git head, and didn't with ~12h older commit. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.