Bug 104405

Summary: XWayland hits assert with xv video output of mpv
Product: xorg Reporter: Corentin Rossignon <corossig>
Component: Server/Acceleration/glamorAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Description Flags
Backtrace when the assert is reached
stderr of XWayland
Patch for renaming sample variable none

Description Corentin Rossignon 2017-12-28 20:45:07 UTC
Created attachment 136429 [details]
Backtrace when the assert is reached


The command :
mpv --vo=xv bisounours_le_film.avi
makes gnome-shell crash because of an unexpected exit of XWayland.

This exit is due to a FatalError("GLSL compile failure\n") of glamor_compile_glsl_prog (see backtrace attached)

Archlinux up-to-date
X.Org X Server 1.19.6                                                                                                              
Gnome-shell 3.26.2
Mesa 17.3.1 (Radeon RX 460)
Comment 1 Michel Dänzer 2017-12-29 08:52:31 UTC
Please attach the corresponding Xwayland stdout/stderr output.
Comment 2 Corentin Rossignon 2017-12-29 09:30:39 UTC
Created attachment 136443 [details]
stderr of XWayland
Comment 3 Corentin Rossignon 2017-12-29 09:32:34 UTC
Thanks for taking care of this problem.
I didn't find the way for getting XWayland output from gnome-shell.
Instead, I used a gdb trick with dup2 of stderr, so I don't have full output but I have the interessed part.
There is nothing inside stdout.
Comment 4 Corentin Rossignon 2017-12-29 09:40:59 UTC
It seems that sample is a keyword in newer OpenGL so it can't be used as name for a variable.
source : https://bugs.freedesktop.org/show_bug.cgi?id=91778
Comment 5 Corentin Rossignon 2017-12-29 10:09:57 UTC
Created attachment 136444 [details] [review]
Patch for renaming sample variable

It tested this patch and it works
Comment 6 Michel Dänzer 2017-12-29 10:19:47 UTC
Please add

Bugzilla: https://bugs.freedesktop.org/104405

and your Signed-off-by tag to the commit log, then send the patch to the xorg-devel mailing list for review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.