Bug 105456

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3915/shard-glkb4/igt@kms_panel_fitting@legacy.html

(kms_panel_fitting:2153) igt_kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file ../lib/igt_kms.c:2498:
(kms_panel_fitting:2153) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:2153) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:2153) igt_kms-CRITICAL: error: -22 != 0
Subtest legacy failed.

This looks like the first occurrence on the GLK issue:

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4349/shard-glkb2/igt@kms_panel_fitting@legacy.html

IGT-Version: 1.22-g8732f0ac (x86_64) (Linux: 4.16.0-rc4-CI-CI_DRM_3911+ x86_64)

it passed on:
IGT-Version: 1.22-g7da16024 (x86_64) (Linux: 4.16.0-rc4-CI-CI_DRM_3911+ x86_64)

this patch was for example merged:
commit 3df9f713602342d13a7b4cf6873addd2105b8153
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Thu Feb 22 13:37:10 2018 +0100

    tests/kms_panel_fitting: Test cleanups.

I can only say that kms_panel_fitting.legacy as it is now is supposed to fail on GLK. The test is trying to use panel fitting and scaling on pipe C, which is not allowed because they have to share scalers. On other pipes for gen9 there are always 2 scalers, but pipe C has one.

I have no idea why this was working before, but it shouldn't have been.

atomic-fastset fails because of confusion between modes:
https://patchwork.freedesktop.org/series/39841/

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_panel_fitting@legacy.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_panel_fitting@legacy.html


(kms_panel_fitting:2840) igt_kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file ../lib/igt_kms.c:2498:
(kms_panel_fitting:2840) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:2840) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:2840) igt_kms-CRITICAL: error: -22 != 0
Subtest legacy failed.

More data coming from shards testlist run on BAT machines:

(kms_panel_fitting:3019) igt_kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file ../lib/igt_kms.c:2498:
(kms_panel_fitting:3019) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:3019) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:3019) igt_kms-CRITICAL: error: -22 != 0
Subtest legacy failed.

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-bxt-dsi/igt@kms_panel_fitting@legacy.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-glk-1/igt@kms_panel_fitting@legacy.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-kbl-r/igt@kms_panel_fitting@legacy.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-skl-6600u/igt@kms_panel_fitting@legacy.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-skl-6700hq/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_2/fi-ilk-m540/igt@kms_panel_fitting@atomic-fastset.html

(kms_panel_fitting:2162) igt_kms-CRITICAL: Test assertion failure function igt_display_commit_atomic, file ../lib/igt_kms.c:3122:
(kms_panel_fitting:2162) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:2162) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:2162) igt_kms-CRITICAL: error: -22 != 0
Subtest atomic-fastset failed.

https://patchwork.freedesktop.org/patch/210589/

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_7/fi-cfl-s3/igt@kms_panel_fitting@legacy.html

(kms_panel_fitting:1790) igt_kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file ../lib/igt_kms.c:2601:
(kms_panel_fitting:1790) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:1790) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:1790) igt_kms-CRITICAL: error: -22 != 0
Subtest legacy failed.

commit 8a26e0e9d99c7f1231250471d11f7decb0ad3d99 (HEAD, origin/master, origin/HEAD)
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Wed Mar 14 11:47:30 2018 +0100

    tests/kms_panel_fitting: Make test pass on gen9's pipe C

(In reply to Maarten Lankhorst from comment #9)
> commit 8a26e0e9d99c7f1231250471d11f7decb0ad3d99 (HEAD, origin/master,
> origin/HEAD)
> Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Date:   Wed Mar 14 11:47:30 2018 +0100
> 
>     tests/kms_panel_fitting: Make test pass on gen9's pipe C

Sorry for the delay. The problems have not been fixed and are still visible every single run...

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-skl-6600u/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-bxt-dsi/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-cfl-s3/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-cfl-u2/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-kbl-7560u/igt@kms_panel_fitting@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_62/fi-kbl-r/igt@kms_panel_fitting@legacy.html

(kms_panel_fitting:2930) igt_kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file ../lib/igt_kms.c:2701:
(kms_panel_fitting:2930) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_panel_fitting:2930) igt_kms-CRITICAL: Last errno: 22, Invalid argument
(kms_panel_fitting:2930) igt_kms-CRITICAL: error: -22 != 0

*** This bug has been marked as a duplicate of bug 106606 ***

(In reply to Maarten Lankhorst from comment #11)
> 
> *** This bug has been marked as a duplicate of bug 106606 ***

Are they really the same issue? :o

Closed as duplicate.

(In reply to Martin Peres from comment #12)
> (In reply to Maarten Lankhorst from comment #11)
> > 
> > *** This bug has been marked as a duplicate of bug 106606 ***
> 
> Are they really the same issue? :o

Reopening since we did not get any answer and the duplication makes no sense to me.

A CI Bug Log filter associated to this bug has been updated:

{- all machines: igt@kms_panel_fitting@(legacy|atomic-fastest) - Test assertion failure function legacy/atomic Failed assertion: ret == 0 -}
{+ all machines: igt@kms_panel_fitting@(legacy|atomic-fastest) - fail/dmesg-fail Test assertion failure function legacy/atomic Failed assertion: ret == 0 +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_256/fi-hsw-peppy/igt@kms_panel_fitting@legacy.html

Bumping the priority since this happens also on shards!

A CI Bug Log filter associated to this bug has been updated:

{- all machines: igt@kms_panel_fitting@(legacy|atomic-fastest) - fail/dmesg-fail Test assertion failure function legacy/atomic Failed assertion: ret == 0 -}
{+ ILK BYT BSW HSW SKL BXT KBL CFL GLK WHL: igt@kms_panel_fitting@(legacy|atomic-fastest) - fail/dmesg-fail Test assertion failure function legacy/atomic Failed assertion: ret == 0 +}

 No new failures caught with the new filter

A CI Bug Log filter associated to this bug has been updated:

{- ILK BYT BSW HSW SKL BXT KBL CFL GLK WHL: igt@kms_panel_fitting@(legacy|atomic-fastest) - fail/dmesg-fail Test assertion failure function legacy/atomic Failed assertion: ret == 0 -}
{+ ILK BYT BSW HSW SKL BXT KBL CFL GLK CML WHL: igt@kms_panel_fitting@(legacy|atomic-fastest) - fail/dmesg-fail Test assertion failure function legacy/atomic Failed assertion: ret == 0 +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_266/fi-cml-u/igt@kms_panel_fitting@legacy.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_267/fi-cml-u/igt@kms_panel_fitting@legacy.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_268/fi-cml-u/igt@kms_panel_fitting@legacy.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_269/fi-cml-u/igt@kms_panel_fitting@legacy.html

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/83.