Bug 105540

Summary: [CI] igt@kms_chamelium@*-edid-change-during-suspend - fail/dmesg-fail - Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Stanislav Lisovskiy <stanislav.lisovskiy>
Status: NEW --- QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: easwar.hariharan, intel-gfx-bugs, martin.peres
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: KBL, SKL i915 features: display/Other
Bug Depends on:    
Bug Blocks: 108757    

Description Marta Löfstedt 2018-03-16 08:22:40 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-kbl-7500u/igt@kms_chamelium@dp-edid-change-during-suspend.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-skl-6700k2/igt@kms_chamelium@hdmi-edid-change-during-suspend.html

(kms_chamelium:1537) CRITICAL: Test assertion failure function test_suspend_resume_edid_change, file ../tests/kms_chamelium.c:403:
(kms_chamelium:1537) CRITICAL: Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)
(kms_chamelium:1537) CRITICAL: Last errno: 11, Resource temporarily unavailable
Comment 1 CI Bug Log 2019-01-31 14:49:55 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-skl-guc fi-kbl-7567u: igt@kms_chamelium@(dp|hdmi)-edid-read - Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) -}
{+ fi-skl-guc fi-kbl-7567u: igt@kms_chamelium@(dp|hdmi)-edid-read - Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_202/fi-kbl-7567u/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
Comment 2 Mun, Gwan-gyeong 2019-02-01 07:48:49 UTC
this patchset ( https://patchwork.freedesktop.org/series/49298/) implements to

dp-edid-change-during-hibernate
dp-edid-change-during-suspend
hdmp-edid-change-during-hibernate
hdmp-edid-change-during-suspend
Comment 3 CI Bug Log 2019-02-08 11:23:17 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-skl-guc fi-kbl-7567u: igt@kms_chamelium@(dp|hdmi)-edid-read - Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) -}
{+ fi-skl-guc fi-kbl-7567u: igt@kms_chamelium@(dp|hdmi)-edid-read - Fail/dmesg-fail Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_211/fi-kbl-7567u/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_206/fi-kbl-7567u/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
Comment 4 CI Bug Log 2019-02-28 15:19:15 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-skl-guc fi-kbl-7567u: igt@kms_chamelium@(dp|hdmi)-edid-read - Fail/dmesg-fail Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) -}
{+ fi-skl-6700k2 fi-kbl-7567u fi-kbl-7500u: igt@kms_chamelium@(dp|hdmi)-edid-read - fail / dmesg-fail -Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) +}

 No new failures caught with the new filter
Comment 5 CI Bug Log 2019-03-27 08:36:10 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-skl-6700k2 fi-kbl-7567u fi-kbl-7500u: igt@kms_chamelium@(dp|hdmi)-edid-read - fail / dmesg-fail -Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) -}
{+ CHAMELIUM: igt@kms_chamelium@(dp|hdmi)-edid-read - fail / dmesg-fail -Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) +}

 No new failures caught with the new filter
Comment 6 Martin Peres 2019-03-27 08:46:02 UTC
*** Bug 108757 has been marked as a duplicate of this bug. ***
Comment 7 CI Bug Log 2019-03-27 08:47:39 UTC
A CI Bug Log filter associated to this bug has been updated:

{- CHAMELIUM: igt@kms_chamelium@(dp|hdmi)-edid-read - fail / dmesg-fail -Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT) -}
{+ CHAMELIUM: igt@kms_chamelium@(dp|hdmi)-edid-read - fail / dmesg-fail -Failed assertion: igt_hotplug_detected(mon, HOTPLUG_TIMEOUT), Last errno: 11, Resource temporarily unavailable +}

 No new failures caught with the new filter
Comment 8 CI Bug Log 2019-03-27 08:48:17 UTC
The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.
Comment 9 Easwar Hariharan 2019-03-27 19:01:34 UTC
(In reply to CI Bug Log from comment #8)
> The CI Bug Log issue associated to this bug has been archived.
> 
> New failures matching the above filters will not be associated to this bug
> anymore.

Does this mean this is not reproducible anymore?
Comment 10 Mun, Gwan-gyeong 2019-04-11 15:49:20 UTC
new patch series updated: https://patchwork.freedesktop.org/series/59352/ 

the patch series addressed  review comments from Maarten.
Comment 11 Mun, Gwan-gyeong 2019-04-21 09:21:54 UTC
Comment addressed patch updated: https://patchwork.freedesktop.org/patch/301078/?series=59691&rev=3
Comment 12 Jani Saarinen 2019-06-03 15:05:24 UTC
gg, do you have any updates on this, where this got stuck? This still seen eg.
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6179/re-icl-u/igt@kms_chamelium@dp-edid-change-during-suspend.html
Comment 13 Stanislav Lisovskiy 2019-06-20 10:33:03 UTC
There are some problems, like i915_hotplug_work_func was actually not calling drm_helper_hpd_irq_event(dev) which we rely on, but drm_kms_helper_hotplug_event(dev) which I guess is wrong as drm_helper_hpd_irq_event itself calls drm_kms_helper_hotplug_event after doing some checks and those patches rely on that drm_helper_hpd_irq_event is called.

Also the edid blob ptr doesn't get updated during probe after suspend, because driver still uses the cached version( I checked that), which makes it impossible to check that the edid actually got changed because the pointer and blob is the same!

To fix this need to call drm_edid_duplicate in drm_helper_hpd_irq_event before doing probing(drm_helper_probe_detect) which will modify connector->edid_blob_ptr and copy it to another blob then compare to the new one.

Currently I'm implementing those fixes.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.