| Summary: | Xfce mouse settings do not apply to wireless mouse after commit 6d3bd4544a | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Evangelos Foutras <evangelos> |
| Component: | Input/libinput | Assignee: | Peter Hutterer <peter.hutterer> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | CC: | peter.hutterer |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | |||
|
Description
Evangelos Foutras
2018-03-21 19:53:38 UTC
Created attachment 138259 [details]
Device settings in xfce4-mouse-settings with xf86-input-libinput 0.26.0 (top) and 0.27.0 (bottom)
Attach an evemu-record of some short 1-2s mouse movement for both logitech event nodes please, thanks. Created attachment 138263 [details]
evemu-record output (mouse)
Created attachment 138264 [details]
evemu-record output (receiver)
I think the problem might be that xf86-input-libinput 0.27.0 no longer sets the LIBINPUT_PROP_LEFT_HANDED property (due to the "if (prop_left_handed != 0) return" conditional?). xfce4-settings seems to look for it in order to know if libinput is used: https://git.xfce.org/xfce/xfce4-settings/tree/xfsettingsd/pointers.c?h=xfce4-settings-4.12.3#n236 A diff of `xinput list-props <mouse-devid>` between 0.26.0 and 0.27.0 shows: $ diff -up <(sed 's/(2..)/(2xx)/' mouse-0.26.0-props.txt | sort) <(sed 's/(2..)/(2xx)/' mouse-0.27.0-props.txt | sort) --- /dev/fd/63 2018-03-22 01:19:17.060693397 +0200 +++ /dev/fd/62 2018-03-22 01:19:17.061693423 +0200 @@ -6,14 +6,12 @@ Device 'Logitech USB Receiver': libinput Accel Profile Enabled (2xx): 1, 0 libinput Accel Profile Enabled Default (2xx): 1, 0 libinput Accel Profiles Available (2xx): 1, 1 - libinput Accel Speed (2xx): -0.600000 + libinput Accel Speed (2xx): 0.000000 libinput Accel Speed Default (2xx): 0.000000 libinput Button Scrolling Button (2xx): 2 libinput Button Scrolling Button Default (2xx): 2 libinput Drag Lock Buttons (2xx): <no items> libinput Horizontal Scroll Enabled (2xx): 1 - libinput Left Handed Enabled (2xx): 0 - libinput Left Handed Enabled Default (2xx): 0 libinput Middle Emulation Enabled (2xx): 0 libinput Middle Emulation Enabled Default (2xx): 0 libinput Natural Scrolling Enabled (2xx): 0 Yeah, that condition seems like detritus left over from testing, can't think of why this would be there. And it would have that effect, only the first pointer-like device will get the left-handed property, everything else misses out. Can you create a git-formatted patch for removing that condition please, I'll get it upstream, thanks. Yay, that must be it! I manually re-added the property and xfce4-mouse-settings is working again. (I should also mention that the receiver node didn't see a change in properties, only the mouse node.) It worked right away after doing the following, without restarting X: $ xinput set-prop 9 --type=int --format=8 "libinput Left Handed Enabled" 0 I'm not sure what the reasoning is behind the addition of "if (prop_left_handed != 0) return", but is it possible to restore the old behavior of always setting LIBINPUT_PROP_LEFT_HANDED? (In reply to Peter Hutterer from comment #6) > Yeah, that condition seems like detritus left over from testing, can't think > of why this would be there. And it would have that effect, only the first > pointer-like device will get the left-handed property, everything else > misses out. Can you create a git-formatted patch for removing that condition > please, I'll get it upstream, thanks. Sure, one patch coming right up. Pretty sure I'll spend half the time trying not to write a silly commit message (due to unfamiliarity with this stuff). I suppose you can fix any obvious issues with it though! Created attachment 138265 [details] [review] [PATCH xf86-input-libinput] Fix "left handed" property not set on all pointers I have successfully tested the attached patch on top of xf86-input-libinput 0.27.0. Thank you for the quick follow up and confirmation on what the issue might be! pushed, thanks.
commit 0db82219bb2ad10dcdf3ea8fe8e226858190c83b
Author: Evangelos Foutras <>
Date: Thu Mar 22 01:47:07 2018 +0200
Fix "left handed" property not set on all pointers
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.