Bug 105749

Summary: [CI] igt@kms_psr_sink_crc@* - fail - Test assertion failure function assert_or_manual - Failed assertion: igt_interactive_debug || condition
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Dhinakaran Pandiyan <dhinakaran.pandiyan>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: dhinakaran.pandiyan, intel-gfx-bugs
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: CFL, CNL i915 features: display/PSR
Bug Depends on:    
Bug Blocks: 105978    

Description Marta Löfstedt 2018-03-26 12:56:42 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_7/fi-cnl-psr/igt@kms_psr_sink_crc@sprite_mmap_gtt_waiting.html

(kms_psr_sink_crc:1558) CRITICAL: Test assertion failure function assert_or_manual, file ../tests/kms_psr_sink_crc.c:285:
(kms_psr_sink_crc:1558) CRITICAL: Failed assertion: igt_interactive_debug || condition
(kms_psr_sink_crc:1558) CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest sprite_mmap_gtt_waiting failed.
Comment 1 Marta Löfstedt 2018-03-26 13:11:11 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_7/fi-cnl-psr/igt@kms_psr_sink_crc@sprite_mmap_gtt.html

(kms_psr_sink_crc:1123) CRITICAL: Test assertion failure function assert_or_manual, file ../tests/kms_psr_sink_crc.c:285:
(kms_psr_sink_crc:1123) CRITICAL: Failed assertion: igt_interactive_debug || condition
(kms_psr_sink_crc:1123) CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest sprite_mmap_gtt failed.
Comment 2 Marta Löfstedt 2018-04-03 06:27:53 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_8/fi-cnl-psr/igt@kms_psr_sink_crc@cursor_mmap_cpu.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_8/fi-cnl-psr/igt@kms_psr_sink_crc@cursor_mmap_gtt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_8/fi-cnl-psr/igt@kms_psr_sink_crc@primary_render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_8/fi-cnl-psr/igt@kms_psr_sink_crc@sprite_plane_onoff.html
	

(kms_psr_sink_crc:1559) CRITICAL: Test assertion failure function assert_or_manual, file ../tests/kms_psr_sink_crc.c:285:
(kms_psr_sink_crc:1559) CRITICAL: Failed assertion: igt_interactive_debug || condition
(kms_psr_sink_crc:1559) CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest sprite_plane_onoff failed.
Comment 4 Marta Löfstedt 2018-04-06 06:44:29 UTC
This is a CRC mismatch issue, I can sometimes reproduce on a HSW Harrishbeach laptop that has a PSR capable display.
Comment 5 Marta Löfstedt 2018-04-09 12:42:42 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_13/fi-cnl-psr/igt@kms_psr_sink_crc@cursor_render.html

(kms_psr_sink_crc:1154) CRITICAL: Test assertion failure function assert_or_manual, file ../tests/kms_psr_sink_crc.c:285:
(kms_psr_sink_crc:1154) CRITICAL: Failed assertion: igt_interactive_debug || condition
(kms_psr_sink_crc:1154) CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest cursor_render failed.
Comment 6 Martin Peres 2018-06-05 06:40:16 UTC
Also seen on CFL: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_56/fi-cfl-u2/igt@kms_psr_sink_crc@suspend.html

(kms_psr_sink_crc:1251) CRITICAL: Test assertion failure function assert_or_manual, file ../tests/kms_psr_sink_crc.c:252:
(kms_psr_sink_crc:1251) CRITICAL: Failed assertion: igt_interactive_debug || condition
(kms_psr_sink_crc:1251) CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest suspend failed.
Comment 7 Dhinakaran Pandiyan 2018-07-14 22:42:15 UTC
This failure should not been anymore, fix merged.


commit 79a6c2dab5d46d55fff0e9f075c4de2a1fd131a2
Author: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Date:   Thu Jul 12 01:09:41 2018 -0700

    tests/kms_psr_sink_crc: Do not test sink crc

    eDP sink crc reads use vblank interrupts that cause PSR exit and
    therefore makes them unsuitable for PSR testing. Besides that, reading
    sink CRC via the AUX channel for testing when the HW also is most likely
    is going to be using AUX channel is a recipe for inconsistent test
    results. Thirdly, CRC's have been seen to be noisy/inconsistent across
    sinks. We tradeoff the ability to validate what the sink is displaying
    for correctness.

    We also make use of source PSR status register to check whether HW tracking
    triggered PSR exit upon an exit event.

    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Comment 8 Lukasz Kalamarz 2018-08-01 12:48:17 UTC
Issue last visible in CI more than 2 weeks ago. Closing this bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.