Bug 105978

Summary: [META] CRC mismatch
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Mika Kahola <mika.kahola>
Status: RESOLVED MOVED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: harish.chegondi, intel-gfx-bugs
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BSW/CHT, BXT, BYT, CFL, CNL, GLK, HSW, ILK, IVB, KBL, SKL, SNB i915 features: display/Other
Bug Depends on: 103166, 103167, 103184, 103191, 103207, 103232, 103286, 103822, 103925, 104671, 104724, 104782, 105749, 108472, 108526, 110038, 110403, 111693    
Bug Blocks:    

Description Marta Löfstedt 2018-04-11 06:27:37 UTC
This is a meta bug to gather all KMS bugs that are filed on CRC mismatches. 

A high number of kms tests on many machines has been flip-flopping on CRC mismatch for a long time. This makes us question if the CRC functionality is working and/or is used in the correct manner. If we still want so many KMS test to based on a CRC comparison, we need to come up with a way to verify the CRC functionality itself.
Comment 1 Marta Löfstedt 2018-04-11 10:00:57 UTC
bug 102614 

[  249.764040] [drm:drm_crtc_add_crc_entry] *ERROR* Overflow of CRC buffer, userspace reads too slow. 

maybe a hint for GLK and SKL.
Comment 2 Francesco Balestrieri 2018-04-27 14:40:46 UTC
Moving to high priority since there is an owner following this
Comment 3 harish.chegondi 2019-05-18 02:49:43 UTC
(In reply to Marta Löfstedt from comment #1)
> bug 102614 
> [  249.764040] [drm:drm_crtc_add_crc_entry] *ERROR* Overflow of CRC buffer,
> userspace reads too slow. 
> maybe a hint for GLK and SKL.

I have noticed the above overflow error message even on BYT. I think this is the reason for this overflow message: IGT tests that read CRC data usually start CRC generation, read CRC data, stop CRC generation and validate the CRC data. Some tests are validating the CRC data even before stopping the CRC generation. If validating the CRC data results in a mismatch and therefore an assert, the test may quit without stopping the CRC generation. This can cause the CRC buffer to get filled up and the overflow error message shows up.

For example, here are few lines from tests/kms_pipe_crc_basic.c test which I think is the correct order - crc is stopped before validating the CRC data. But there are some tests which validate the CRC data before stopping the CRC. For example, in tests/kms_rotation_crc.c test_plane_rotation(), CRC data is validated before stopping the CRC.

From: from tests/kms_pipe_crc_basic.c:
pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);

n_crcs = igt_pipe_crc_get_crcs(pipe_crc, N_CRCS, &crcs);


/* and ensure that they'are all equal, we haven't changed the fb */
for (j = 0; j < (n_crcs - 1); j++)
    igt_assert_crc_equal(&crcs[j], &crcs[j + 1]);
Comment 4 Lakshmi 2019-08-21 10:49:25 UTC
Since each bug has got it's own priority, dropping the priority of this META bug to Medium.
Comment 5 Martin Peres 2019-11-29 17:44:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/101.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.