Bug 106370

Created attachment 139315 [details]
attachment-6921-0.html

What version of cmake are you using?

I'm on mobile, please excuse autocorrect fail.

On Wed, May 2, 2018, 23:01 <bugzilla-daemon@freedesktop.org> wrote:

> Bug ID 106370 <https://bugs.freedesktop.org/show_bug.cgi?id=106370>
> Summary /bin/sh: BYPRODUCTS: command not found
> Product piglit
> Version unspecified
> Hardware x86-64 (AMD64)
> OS All
> Status NEW
> Keywords regression
> Severity normal
> Priority medium
> Component infrastructure
> Assignee baker.dylan.c@gmail.com
> Reporter vlee@freedesktop.org
> QA Contact piglit@lists.freedesktop.org
>
> Build error with older cmake.
>
> [  1%] Built target gen-gl-tests
> /bin/sh: BYPRODUCTS: command not found
> make[2]: *** [target_api/no_api/tests/CMakeFiles/static-shader-tests] Error 127
>
> ------------------------------
> You are receiving this mail because:
>
>    - You are the assignee for the bug.
>
>

(In reply to Dylan Baker from comment #1)
> 
> What version of cmake are you using?
> 

2.8.12.2

Build error introduced with this commit.

commit 2f02cf0d4c2d7e901415d2325200deccc4230123
Author: Dylan Baker <dylan@pnwbakers.com>
Date:   Wed Mar 28 14:50:31 2018 -0700

    Generate xml for builtin profiles
    
    This creates and installs xml for all builtin profiles. Using these
    profiles I see startup times of ~1 second as opposed to more than 10
    with current master, and runtimes that drop by ~1 minute.
    
    v2: - Fix compilation with make. v1 only worked with ninja.
    
    Tested-by: Rafael Antognolli <rafael.antognolli@intel.com>

commit fdc5a4ca11124ab8413c7988896eec4c97336694
Author: Vinson Lee <vlee@freedesktop.org>
Date:   Thu May 17 11:29:53 2018 -0700

    cmake: Bump minimum version to 3.2.
    
    This build error occurs with cmake 2.8.12.
    /bin/sh: BYPRODUCTS: command not found
    
    BYPRODUCTS is not available until cmake 3.2.
    https://cmake.org/cmake/help/v3.2/release/3.2.html
    
    Fixes: 2f02cf0d4c2d ("Generate xml for builtin profiles")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106370
    Signed-off-by: Vinson Lee <vlee@freedesktop.org>
    Reviewed-by: Dylan Baker <dylan@pnwbakers.com>