Bug 106386

Summary: [CI] igt@*(suspend)* - dmesg-warn - (PCH|CPU) PWM1 enabled
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: REOPENED --- QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs, tomi.p.sarvela
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BDW, HSW i915 features: display/Other, power/suspend-resume

Description Martin Peres 2018-05-03 16:08:18 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_30/fi-hsw-peppy/igt@pm_rpm@system-suspend-execbuf.html

[  292.579711] ------------[ cut here ]------------
[  292.579718] CPU PWM1 enabled
[  292.579875] WARNING: CPU: 0 PID: 145 at drivers/gpu/drm/i915/intel_display.c:8871 hsw_enable_pc8+0x643/0x680 [i915]
[  292.579882] Modules linked in: snd_hda_codec_hdmi x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel i915 cdc_ether snd_hda_codec_realtek snd_hda_codec_generic usbnet r8152 mii snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_pcm mei_me lpc_ich mei prime_numbers btusb btrtl btbcm btintel bluetooth ecdh_generic
[  292.580039] CPU: 0 PID: 145 Comm: kworker/0:2 Tainted: G     U            4.17.0-rc3-g844dd95837ab-drmtip_30+ #1
[  292.580045] Hardware name: GOOGLE Peppy/Peppy, BIOS MrChromebox 02/04/2018
[  292.580057] Workqueue: pm pm_runtime_work
[  292.580177] RIP: 0010:hsw_enable_pc8+0x643/0x680 [i915]
[  292.580185] RSP: 0018:ffffaff7801e3d00 EFLAGS: 00010286
[  292.580196] RAX: 0000000000000000 RBX: ffff927f1c330000 RCX: 0000000000000001
[  292.580202] RDX: 0000000080000001 RSI: ffffffffa10855ee RDI: 00000000ffffffff
[  292.580208] RBP: ffff927f1c330868 R08: 000000009f549cfb R09: 0000000000000000
[  292.580214] R10: 0000000000000000 R11: 0000000000000000 R12: ffff927f1c330878
[  292.580220] R13: ffffffffc0374354 R14: 0000000000000000 R15: ffffffffa0501e40
[  292.580227] FS:  0000000000000000(0000) GS:ffff927fc0200000(0000) knlGS:0000000000000000
[  292.580234] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  292.580240] CR2: 00005617e97a2ef0 CR3: 0000000030210006 CR4: 00000000000606f0
[  292.580247] Call Trace:
[  292.580269]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.580349]  intel_runtime_suspend+0x114/0x230 [i915]
[  292.580363]  pci_pm_runtime_suspend+0x57/0x170
[  292.580379]  __rpm_callback+0xb7/0x1f0
[  292.580390]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.580403]  rpm_callback+0x1a/0x70
[  292.580414]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.580423]  rpm_suspend+0x125/0x6d0
[  292.580446]  pm_runtime_work+0x6e/0xb0
[  292.580458]  process_one_work+0x229/0x6a0
[  292.580480]  worker_thread+0x35/0x380
[  292.580495]  ? process_one_work+0x6a0/0x6a0
[  292.580505]  kthread+0x119/0x130
[  292.580515]  ? _kthread_create_on_node+0x60/0x60
[  292.580532]  ret_from_fork+0x3a/0x50
[  292.580560] Code: ff ff e8 c1 86 db df 0f 0b e9 df fb ff ff e8 b5 86 db df 0f 0b e9 b4 fa ff ff e8 a9 86 db df 0f 0b e9 87 fa ff ff e8 9d 86 db df <0f> 0b e9 21 fb ff ff e8 91 86 db df 0f 0b e9 f4 fa ff ff e8 85 
[  292.580872] irq event stamp: 16614
[  292.580886] hardirqs last  enabled at (16613): [<ffffffffa00fc056>] console_unlock+0x426/0x640
[  292.580897] hardirqs last disabled at (16614): [<ffffffffa0a0111c>] error_entry+0x7c/0x100
[  292.580906] softirqs last  enabled at (16460): [<ffffffffa0c0032b>] __do_softirq+0x32b/0x4e1
[  292.580917] softirqs last disabled at (16453): [<ffffffffa008f6c4>] irq_exit+0xa4/0xb0
[  292.581037] WARNING: CPU: 0 PID: 145 at drivers/gpu/drm/i915/intel_display.c:8871 hsw_enable_pc8+0x643/0x680 [i915]
[  292.581044] ---[ end trace 3af0a4dd0284045e ]---
[  292.581091] ------------[ cut here ]------------
[  292.581098] PCH PWM1 enabled
[  292.581246] WARNING: CPU: 0 PID: 145 at drivers/gpu/drm/i915/intel_display.c:8876 hsw_enable_pc8+0x613/0x680 [i915]
[  292.581252] Modules linked in: snd_hda_codec_hdmi x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel i915 cdc_ether snd_hda_codec_realtek snd_hda_codec_generic usbnet r8152 mii snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_pcm mei_me lpc_ich mei prime_numbers btusb btrtl btbcm btintel bluetooth ecdh_generic
[  292.581401] CPU: 0 PID: 145 Comm: kworker/0:2 Tainted: G     U  W         4.17.0-rc3-g844dd95837ab-drmtip_30+ #1
[  292.581406] Hardware name: GOOGLE Peppy/Peppy, BIOS MrChromebox 02/04/2018
[  292.581416] Workqueue: pm pm_runtime_work
[  292.581540] RIP: 0010:hsw_enable_pc8+0x613/0x680 [i915]
[  292.581549] RSP: 0018:ffffaff7801e3d00 EFLAGS: 00010286
[  292.581559] RAX: 0000000000000000 RBX: ffff927f1c330000 RCX: 0000000000000001
[  292.581565] RDX: 0000000080000001 RSI: ffffffffa10855ee RDI: 00000000ffffffff
[  292.581571] RBP: ffff927f1c330868 R08: 000000009f549cfb R09: 0000000000000000
[  292.581577] R10: 0000000000000000 R11: 0000000000000000 R12: ffff927f1c330878
[  292.581583] R13: ffffffffc0374354 R14: 0000000000000000 R15: ffffffffa0501e40
[  292.581591] FS:  0000000000000000(0000) GS:ffff927fc0200000(0000) knlGS:0000000000000000
[  292.581597] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  292.581604] CR2: 00005617e97a2ef0 CR3: 0000000030210006 CR4: 00000000000606f0
[  292.581609] Call Trace:
[  292.581626]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.581705]  intel_runtime_suspend+0x114/0x230 [i915]
[  292.581718]  pci_pm_runtime_suspend+0x57/0x170
[  292.581733]  __rpm_callback+0xb7/0x1f0
[  292.581743]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.581756]  rpm_callback+0x1a/0x70
[  292.581766]  ? pci_pm_runtime_resume+0xa0/0xa0
[  292.581776]  rpm_suspend+0x125/0x6d0
[  292.581798]  pm_runtime_work+0x6e/0xb0
[  292.581808]  process_one_work+0x229/0x6a0
[  292.581830]  worker_thread+0x35/0x380
[  292.581844]  ? process_one_work+0x6a0/0x6a0
[  292.581853]  kthread+0x119/0x130
[  292.581865]  ? _kthread_create_on_node+0x60/0x60
[  292.581880]  ret_from_fork+0x3a/0x50
[  292.581908] Code: ff ff e8 f1 86 db df 0f 0b e9 a1 fa ff ff e8 e5 86 db df 0f 0b e9 f6 fb ff ff e8 d9 86 db df 0f 0b e9 c9 fb ff ff e8 cd 86 db df <0f> 0b e9 9c fb ff ff e8 c1 86 db df 0f 0b e9 df fb ff ff e8 b5 
[  292.582219] irq event stamp: 16642
[  292.582230] hardirqs last  enabled at (16641): [<ffffffffa00fc056>] console_unlock+0x426/0x640
[  292.582240] hardirqs last disabled at (16642): [<ffffffffa0a0111c>] error_entry+0x7c/0x100
[  292.582249] softirqs last  enabled at (16624): [<ffffffffa0c0032b>] __do_softirq+0x32b/0x4e1
[  292.582259] softirqs last disabled at (16617): [<ffffffffa008f6c4>] irq_exit+0xa4/0xb0
[  292.582378] WARNING: CPU: 0 PID: 145 at drivers/gpu/drm/i915/intel_display.c:8876 hsw_enable_pc8+0x613/0x680 [i915]
[  292.582385] ---[ end trace 3af0a4dd0284045f ]---
Comment 1 Chris Wilson 2018-09-09 08:49:06 UTC
So the PWM1 complaint, afaict, is about the backlight being left on when the displays are off. I think this is to us detecting the backlight HW state as being enabled but the corresponding pipe being off (i.e. we inherit the state from the BIOS and lack the wherewithal to sanitize it).
Comment 2 Chris Wilson 2018-09-14 20:49:17 UTC
*** Bug 107603 has been marked as a duplicate of this bug. ***
Comment 3 Ville Syrjala 2018-10-09 13:37:35 UTC
commit 19dfe5726bab6d2ef337b3051d5a96868a875ac4
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Mon Oct 8 16:46:40 2018 +0300

    drm/i915: Do intel_panel_destroy_backlight() later
Comment 5 Ville Syrjala 2018-11-19 18:53:09 UTC
(In reply to Lakshmi from comment #4)
> Ville, this issue is still occurring 
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_131/fi-hsw-peppy/
> igt@pm_rpm@system-suspend-execbuf.html

Bah. I suspect the silly BIOS is turning the pwm back on during S3 :(
Comment 6 CI Bug Log 2019-02-06 16:00:44 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-hsw-peppy: igt@*(s3|s4|suspend|hibernate) - dmesg-warn - (CPU|PCH) PWM1 enabled -}
{+ fi-hsw-peppy: igt@*(s3|s4|suspend|hibernate) - dmesg-warn - (CPU|PCH) PWM1 enabled +}

 No new failures caught with the new filter
Comment 7 CI Bug Log 2019-02-06 16:03:31 UTC
A CI Bug Log filter associated to this bug has been updated:

{- HSW: igt@runner@aborted- fail - Previous test: pm_rpm (system-suspend-(execbuf|modeset))|Previous test: pm_rpm (system-suspend\) -}
{+ HSW: igt@runner@aborted- fail - Previous test: pm_rpm (system-suspend*) +}

 No new failures caught with the new filter
Comment 8 CI Bug Log 2019-02-07 11:07:41 UTC
A CI Bug Log filter associated to this bug has been updated:

{- HSW: igt@runner@aborted- fail - Previous test: pm_rpm (system-suspend*) -}
{+ HSW: igt@runner@aborted- fail - Previous test: pm_rpm (system-suspend*) / pm_backlight +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_207/fi-hsw-peppy/igt@runner@aborted.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_208/fi-hsw-peppy/igt@runner@aborted.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_209/fi-hsw-peppy/igt@runner@aborted.html

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.