Bug 107693

Created attachment 141291 [details]
wine wgl log

This is an odd one. The games rendering thread creates and uses a compat profile but when it checks extensions it actually creates a core profile in another thread.

It ends up failing to find GL_EXT_framebuffer_object because its checking the core profile rather than the compat profile (in mesa this extension is currently only enable for the comapt profile).

AFAIK none of the id Tech 5/6 actually uses any legacy stuff. The compatibility context is only used for initial probing by the GLEW library.

Looks like the Nvidia driver exposes GL_EXT_framebuffer_object in core profiles.

The ARB and EXT variants supposedly differ somewhat so I guess it's done for compatibility?

(In reply to Sven Arvidsson from comment #4)
> Looks like the Nvidia driver exposes GL_EXT_framebuffer_object in core
> profiles.
> 
> The ARB and EXT variants supposedly differ somewhat so I guess it's done for
> compatibility?

The game also looks for ARB_vertex_buffer_object in core (which mesa doesn't expose) and tries to use EXT_direct_state_access without checking for it.

I've enabled these extensions and added a partial implementation of EXT_direct_state_access but the game is crashing so I'm still missing something [1].

The EXT_direct_state_access implementation does work well enough to be able to run Doom (2016) which uses the extension when it detects it. 


[1] https://gitlab.freedesktop.org/tarceri/mesa/commits/EXT_direct_state_access

Unsure if this helps or not, but before mesa's profiles were updated I was able to get the game running using this patch:

https://gitlab.com/GloriousEggroll/wolfenstein-tno-tob-linux/blob/master/idtech5.patch

and setting
MESA_GL_VERSION_OVERRIDE=4.5COMPAT

this was working with wine 2.17 at the time

this patch was for wine btw, not mesa, but maybe it can be used to find what wine was providing that allowed the game to start

(In reply to gloriouseggroll from comment #6)
> Unsure if this helps or not, but before mesa's profiles were updated I was
> able to get the game running using this patch:
> 
> https://gitlab.com/GloriousEggroll/wolfenstein-tno-tob-linux/blob/master/
> idtech5.patch
> 
> and setting
> MESA_GL_VERSION_OVERRIDE=4.5COMPAT
> 
> this was working with wine 2.17 at the time

I'm not sure how that was possible, without my partial EXT_direct_state_access implementation I just get a green screen.

Anyway it seems the game also requires ARB_vertex_program exposed in the core profile. With this I can now play the game on my EXT_direct_state_access branch.

it may have been using 3.3compat or 3.2compat, dont remember which, but that patch was working with both games

FWIW, the patch doesn't apply cleanly, but still works with Wine 3.15. The game starts and looks ok with  MESA_GLSL_VERSION_OVERRIDE=150 MESA_GL_VERSION_OVERRIDE=3.2COMPAT (both on 18.0.5 without real compatibility and on 18.2).

But for all I know. it might break horribly after the first few minutes. 

(In reply to Timothy Arceri from comment #8)
> Anyway it seems the game also requires ARB_vertex_program exposed in the
> core profile. With this I can now play the game on my
> EXT_direct_state_access branch.

That is awesome! Thanks for working on this!

Should be fixed by:

commit 64ec50d52fa691cc1712df1d7eebea90552b7c2e
Author: Timothy Arceri <tarceri@itsqueeze.com>
Date:   Wed Sep 12 10:52:06 2018 +1000

    mesa/st: add force_compat_profile option to driconfig
    
    Reviewed-by: Marek Olšák <marek.olsak@amd.com>

and

commit 024abd3534a171ae4ee1532a078f3af68eb6fdea (HEAD -> master)
Author: Timothy Arceri <tarceri@itsqueeze.com>
Date:   Wed Sep 12 10:52:07 2018 +1000

    util: use force_compat_profile for Wolfenstein The Old Blood
    
    This game is looking for some odd extension after creating a core
    context such as ARB_vertex_program and EXT_framebuffer_object.
    
    Rather then enabling these in core this forces the game to use
    compat. This allows the game to run and seems to work without
    issues. All other id tech games/engines use a compat profile.
    
    Reviewed-by: Marek Olšák <marek.olsak@amd.com>

As for the green screen that is a bug with wine staging. Proton and older versions of wine staging were fine. See: https://bugs.winehq.org/show_bug.cgi?id=45826

We've removed the broken opengl patchset in wine-staging. Seems the problems it resolved originally have all been resolved in wine already. Should be effective next release. it was also affecting DOOM 2016.

https://github.com/wine-staging/wine-staging/commits/master
commit: bd3794c11e682e8489959ff79405396f742ee7c4

can confirm after your patches wolfenstein TOB works perfectly. thank you!