| Summary: | SPV_GOOGLE_hlsl_functionality1 / SPV_GOOGLE_decorate_string | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | xbx <xavierb> |
| Component: | Drivers/Vulkan/Common | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | airlied, chadversary, daniel, jason |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | example spirv from dxc.exe | ||
Is there any extension for supporting these in vulkan? Only Google extensions I can find in the Vulkan spec are VK_GOOGLE_display_timing and VK_ANDROID_external_memory_android_hardware_buffer. I don't know. I don't think so. It's only an spv extentension to add some additional reflection info to help with porting from hlsl. https://github.com/KhronosGroup/SPIRV-Registry/blob/master/extensions/GOOGLE/SPV_GOOGLE_hlsl_functionality1.asciidoc Patches are on the list. Mind giving them a try? https://patchwork.freedesktop.org/series/50971/ thanks. the patches work fine. If you want to give me a "Tested-by" tag, I'll happily add it to the patch before pushing. Should be resolved with the following commit. Feel free to reopen otherwise. commit ca4e465f7d018f8702ddb5332bf1c892b1808366 Author: Jason Ekstrand <jason.ekstrand@intel.com> Date: Sat Oct 13 08:46:20 2018 -0500 anv,radv: Trivially expose two new VK_GOOGLE extensions |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 141626 [details] example spirv from dxc.exe hi, Trying to use the "dxc" compiler to compile hlsl -> spirv and enabling additional reflection decorations produces a spirv binary that is rejected by mesa. Seems to me it's because decorations of type "OpDecorateStringGOOGLE" "OpMemberDecorateStringGOOGLE" appear in the header and cause vtn_handle_preamble_instruction() to move on to the next section prematurely. (if I understand correctly they should just be skipped?)