Created attachment 141626 [details]
example spirv from dxc.exe
Trying to use the "dxc" compiler to compile hlsl -> spirv and enabling additional reflection decorations produces a spirv binary that is rejected by mesa.
Seems to me it's because decorations of type "OpDecorateStringGOOGLE" "OpMemberDecorateStringGOOGLE" appear in the header and cause vtn_handle_preamble_instruction() to move on to the next section prematurely.
(if I understand correctly they should just be skipped?)
Is there any extension for supporting these in vulkan? Only Google extensions I can find in the Vulkan spec are VK_GOOGLE_display_timing and VK_ANDROID_external_memory_android_hardware_buffer.
I don't know. I don't think so.
It's only an spv extentension to add some additional reflection info to help with porting from hlsl.
Patches are on the list. Mind giving them a try?
the patches work fine.
If you want to give me a "Tested-by" tag, I'll happily add it to the patch before pushing.
Should be resolved with the following commit. Feel free to reopen otherwise.
Author: Jason Ekstrand <firstname.lastname@example.org>
Date: Sat Oct 13 08:46:20 2018 -0500
anv,radv: Trivially expose two new VK_GOOGLE extensions