Bug 108739

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_142/fi-cfl-8109u/igt@kms_content_protection@atomic.html

Starting subtest: atomic
(kms_content_protection:1355) CRITICAL: Test assertion failure function test_cp_enable_disable, file ../tests/kms_content_protection.c:181:
(kms_content_protection:1355) CRITICAL: Failed assertion: ret
(kms_content_protection:1355) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_content_protection:1355) CRITICAL: Content Protection not enabled

<3> [441.461452] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-110)
<3> [464.142465] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-110)
<3> [486.870876] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-110)


https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_142/fi-icl-u2/igt@kms_content_protection@atomic.html

Starting subtest: atomic
(kms_content_protection:1369) CRITICAL: Test assertion failure function test_cp_enable_disable, file ../tests/kms_content_protection.c:181:
(kms_content_protection:1369) CRITICAL: Failed assertion: ret
(kms_content_protection:1369) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_content_protection:1369) CRITICAL: Content Protection not enabled

<3> [649.397993] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-6)
<3> [673.370491] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-6)
<3> [697.342911] [drm:_intel_hdcp_enable [i915]] *ERROR* Could not load HDCP keys, (-6)

Martin,

How to get the current status of this issue on cfl? if I check at https://intel-gfx-ci.01.org/tree/drm-tip/combined-issues-by-run.html cfl is used for fast feedback where content protection tests are not executed.

And shards-iclb has no connector with hdcp capability. I am not sure how did we get these observations. Could you please help on this?

(In reply to Ramalingam C from comment #2)
> Martin,
> 
> How to get the current status of this issue on cfl? if I check at
> https://intel-gfx-ci.01.org/tree/drm-tip/combined-issues-by-run.html cfl is
> used for fast feedback where content protection tests are not executed.
> 
> And shards-iclb has no connector with hdcp capability. I am not sure how did
> we get these observations. Could you please help on this?

Sorry for the delay. What you want to look at is the CI-wide idle runs: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html (link can be found in https://intel-gfx-ci.01.org).

In the future, I would like people to use CI Bug Log to find all the failures associated to a bug, but that will require a bit more development (a non-intel-hosted instance).

CFL HDCP1.4 key load issue is locally verified to be fixed by https://patchwork.freedesktop.org/patch/265985/

The series https://patchwork.freedesktop.org/series/53493/ is awaiting the merger

ICL needs to be debugged yet.

(In reply to Ramalingam C from comment #4)
> CFL HDCP1.4 key load issue is locally verified to be fixed by
> https://patchwork.freedesktop.org/patch/265985/
> 
> The series https://patchwork.freedesktop.org/series/53493/ is awaiting the
> merger
> 
> ICL needs to be debugged yet.

Thanks! CFL is not seeing the "Could not load HDCP keys" error anymore, but it still fails:

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_158/fi-cfl-8109u/igt@kms_content_protection@legacy.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_158/fi-cfl-8109u/igt@kms_content_protection@atomic.html

Starting subtest: atomic
(kms_content_protection:1140) CRITICAL: Test assertion failure function test_cp_enable_disable, file ../tests/kms_content_protection.c:183:
(kms_content_protection:1140) CRITICAL: Failed assertion: ret
(kms_content_protection:1140) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_content_protection:1140) CRITICAL: Content Protection not enabled
Subtest atomic failed.

Martin difficult to fix this, as this is not reproducible on the CFL/KBL I have tested locally. When I can use the fi-cfl-8109u or problematic KBL fi system, for debugging, we can fix this.

Mostly errors are KSV list not available on DP port which mean LSPCon related issues.

A CI Bug Log filter associated to this bug has been updated:

{- CFL: igt@kms_content_protection@* - fail - Content Protection not enabled -}
{+ APL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4827/shard-apl3/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5601/shard-apl1/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5602/shard-apl7/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5604/shard-apl3/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5605/shard-apl8/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5603/shard-apl5/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5606/shard-apl1/igt@kms_content_protection@atomic-dpms.html

A CI Bug Log filter associated to this bug has been updated:

{- APL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled -}
{+ APL KBL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4827/shard-kbl7/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5601/shard-kbl3/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5602/shard-kbl7/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5604/shard-kbl6/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5605/shard-kbl3/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5603/shard-kbl1/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5606/shard-kbl3/igt@kms_content_protection@atomic-dpms.html

(In reply to CI Bug Log from comment #8)
> A CI Bug Log filter associated to this bug has been updated:
> 
> {- APL CFL: igt@kms_content_protection@* - fail - Content Protection not
> enabled -}
> {+ APL KBL CFL: igt@kms_content_protection@* - fail - Content Protection not
> enabled +}
> 
> New failures caught by the filter:
> 
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4827/shard-kbl7/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5601/shard-kbl3/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5602/shard-kbl7/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5604/shard-kbl6/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5605/shard-kbl3/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5603/shard-kbl1/
> igt@kms_content_protection@atomic-dpms.html
> *
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5606/shard-kbl3/
> igt@kms_content_protection@atomic-dpms.html

Since the failures are from BAT, priority is set to highest.

Ramalingam, any updates here?

A CI Bug Log filter associated to this bug has been updated:

{- APL KBL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled -}
{+ APL SKL KBL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_221/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_221/fi-skl-gvtdvm/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_222/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_222/fi-skl-gvtdvm/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_223/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_224/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_224/fi-skl-gvtdvm/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_225/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_225/fi-skl-gvtdvm/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_226/fi-skl-6770hq/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_226/fi-skl-gvtdvm/igt@kms_content_protection@atomic-dpms.html

Ramalingam, This issue is seen on SKL.

A CI Bug Log filter associated to this bug has been updated:

{- APL SKL KBL CFL: igt@kms_content_protection@* - fail - Content Protection not enabled -}
{+ APL SKL KBL CFL ICL: igt@kms_content_protection@* - fail - Content Protection not enabled +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_228/fi-icl-u2/igt@kms_content_protection@atomic-dpms.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_229/fi-icl-u2/igt@kms_content_protection@atomic-dpms.html

Martin,

We need to file different bugs for the content protection failures based on the cause for it. 
This is needed because few failures are due to the HDCP sink, which can't be fixed.

The cause has to be picked from the kernel demsg debug logs as given below. 

1. [drm:intel_hdcp_read_valid_bksv.isra.0 [i915]] Bksv is invalid
      Ex: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3967/fi-icl-u3/igt@kms_content_protection@legacy.html

2. [drm:intel_hdcp_auth [i915]] KSV list failed to become ready (-110)
      Ex: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5750/shard-kbl5/igt@kms_content_protection@atomic.html


Could you please help with this?

This bug can be used to track the content protection enable failure due to the HDCP key load issue. But I believe this is no more seen on the latest HDCP results.

We need a dmesg filter for

<7> [250.501050] [drm:intel_hdcp_auth [i915]] Timed out waiting for Ri prime match (50000)


and the specific shard machine (all the ones with dongles) to filter out the HDCP sink issues due to dongles. I had lots of chats with Ram and unfortunately we can't detect lack of proper HDCP support in sinks in any kind of reliable way.

To clarify: Anything that doesn't match the dmesg line would indicate a host side hdcp issue (like the failed to load hdcp keys), which we need to fix. The sinke side issues can be closed as WONTIFX/NOTABUG.

Correction about #15: This isn't the first message that we'd print when the sink isn't hdcp capabe. So could also be a flaky issue on i915 side (hdcp uses special gpio/gmbus/i2c mode, so could be a bug there). No hdcp sink support should always fail the same way.

/me puzzled.

Thanks Daniel! I'll split this bug into 2:
 - close as NOTABUG the sink issues that cannot be fixed
 - the i915 issues should be going into their own respective bug, with a HIGH priority because the only customer impact is the inability to play protected content.

The CI Bug Log issue associated to this bug has been updated.

### Removed filters

* APL SKL KBL CFL ICL: igt@kms_content_protection@* - fail - Content Protection not enabled (added on 1 month, 1 week ago)

(In reply to CI Bug Log from comment #19)
> The CI Bug Log issue associated to this bug has been updated.
> 
> ### Removed filters
> 
> * APL SKL KBL CFL ICL: igt@kms_content_protection@* - fail - Content
> Protection not enabled (added on 1 month, 1 week ago)

Moved to https://bugs.freedesktop.org/show_bug.cgi?id=110336

Dropping to high, since it is visible on drmtip runs and on an upcoming platform. Please check if this is due to the HDMI dongles.

@Ram, Last seen on ICL drmtip_247 (3 weeks, 1 day old).
On other platforms, failure used to occur on every round but till CI_DRM_5874_full (5 days, 19 hours old).

(In reply to Martin Peres from comment #21)
> Dropping to high, since it is visible on drmtip runs and on an upcoming
> platform. Please check if this is due to the HDMI dongles.

Martin and Lakshmi,

I am not able to find this hdcp key load issue at the result of 		CI_DRM_5902 from https://intel-gfx-ci.01.org/tree/drm-tip/

(In reply to Ramalingam C from comment #23)
> (In reply to Martin Peres from comment #21)
> > Dropping to high, since it is visible on drmtip runs and on an upcoming
> > platform. Please check if this is due to the HDMI dongles.
> 
> Martin and Lakshmi,
> 
> I am not able to find this hdcp key load issue at the result of 	
> CI_DRM_5902 from https://intel-gfx-ci.01.org/tree/drm-tip/

Ram, sorry for the delay.
Last this issue (*ERROR* Could not load HDCP keys) in drmtip_218 (2 months old). Most likely this issue is closed.

The filter was updated a week ago to catch failures related to "*ERROR* Could not load HDCP keys". I think we can wait for another week and close this bug if we don't see any failure meantime.

Update to myself: Priority is dropped to low as this issue is not seen lately. Wait for another week and close this bug if no failures are occurred.

This issue used to occur on every CI_DRM run. At the moment last seen (2 months, 3 weeks old). Closing this bug as WORKSFORME.

The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.