Bug 108829

Summary:	[meson] libglapi exports internal API
Product:	Mesa	Reporter:	Emil Velikov <emil.l.velikov>
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium	CC:	baker.dylan.c, fdo-bugs
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Emil Velikov 2018-11-22 11:33:16 UTC

Seems like we're missing visibility flags here. We export 39 symbols, instead of 19.

Might be having a look throughout mesa comparing the meson and autotools builds.
Personally I use `nm -CD --defined-only` but objdump and others can also be utilised ;-)

Comment 1 Emil Velikov 2018-11-22 11:35:16 UTC

Cc-ing some people. Props to the freedesktop-sdk people for spotting it.

Comment 2 Eric Engestrom 2018-11-22 18:24:26 UTC

Fixed as of:

commit 896c59d690e38e92682f9bc509b5e3658aba5670
Author: Eric Engestrom <eric.engestrom@intel.com>
Date:   Thu Nov 22 13:33:28 2018 +0000

    glapi: add missing visibility args
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108829
    Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack"
    Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.