Bug 108829 - [meson] libglapi exports internal API
Summary: [meson] libglapi exports internal API
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-22 11:33 UTC by Emil Velikov
Modified: 2018-11-22 18:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Velikov 2018-11-22 11:33:16 UTC
Seems like we're missing visibility flags here. We export 39 symbols, instead of 19.

Might be having a look throughout mesa comparing the meson and autotools builds.
Personally I use `nm -CD --defined-only` but objdump and others can also be utilised ;-)
Comment 1 Emil Velikov 2018-11-22 11:35:16 UTC
Cc-ing some people. Props to the freedesktop-sdk people for spotting it.
Comment 2 Eric Engestrom 2018-11-22 18:24:26 UTC
Fixed as of:

commit 896c59d690e38e92682f9bc509b5e3658aba5670
Author: Eric Engestrom <eric.engestrom@intel.com>
Date:   Thu Nov 22 13:33:28 2018 +0000

    glapi: add missing visibility args
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108829
    Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack"
    Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.