| Summary: | Vkd3d test failure test_clear_render_target_view() | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Timothy Arceri <t_arceri> |
| Component: | Drivers/Vulkan/intel | Assignee: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | jason, joseph.kucia, siglesias, t_arceri |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=108910 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Aub dump with simplified test
Untested patch Compile-tested patch |
||
|
Description
Timothy Arceri
2018-11-30 04:14:50 UTC
Created attachment 142718 [details]
Aub dump with simplified test
I've reduced the test to clear & resolve 2 layers only.
The clear color of layer0 ends up in the layer1.
Adding a texture cache invalidate between resolve of layer 0 & 1 fixes the issue. Not quite sure what's going on here...
Created attachment 142719 [details] [review] Untested patch The attached patch (which I haven't even compile-tested) should fix the issue with MCS partial resolves. We also should probably stop even doing them in anv (as per Lionel's patch). Created attachment 142720 [details] [review] Compile-tested patch The new patch builds. (In reply to Jason Ekstrand from comment #3) > Created attachment 142720 [details] [review] [review] > Compile-tested patch > > The new patch builds. Unfortunately, not fixing the issue :( I'm writing a new crucible test to track that regression. The following error doesn't happen if I run it on BDW, which does not execute the fast clear path: d3d12:3506: Test failed: Got 0xbf4c8019, expected 0xbf95bc59 at (0, 0, 0). So I ran the test disabling fast clear on sRGB on my Kabylake laptop and this error is gone too. It seems there is an issue with fast-clearing on sRGB on gen9. Looks like Gen9 doesn't support fast clear on single-sampled SRGB buffers. This MR should fix the last 2 failures reported in the first comment : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/40 Looks like there is an additional issue with sRGB that Samuel is looking at. (In reply to Lionel Landwerlin from comment #7) > This MR should fix the last 2 failures reported in the first comment : > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/40 > > Looks like there is an additional issue with sRGB that Samuel is looking at. Pushed to master. I have this series for the SRGB resolve issue : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/50/ A fix landed as ("e2ae5f2f0a anv: don't do partial resolve on layer > 0").
Can we close this as FIXED?
(In reply to Juan A. Suarez from comment #10) > A fix landed as ("e2ae5f2f0a anv: don't do partial resolve on layer > 0"). > > Can we close this as FIXED? There are 2 issues in this bug, first one is resolved with the commit you mentioned. Second one needs this MR : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/50 Second issue also fixed at : https://gitlab.freedesktop.org/mesa/mesa/commit/add5a2ec92f4b3f7ac8353e5986dc04186a7b6da commit add5a2ec92f4b3f7ac8353e5986dc04186a7b6da Author: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Date: Sun Dec 23 17:49:23 2018 +0000 anv: flush fast clear colors into compressed surfaces Thanks! I can confirm that vkd3d test failures reported in this bug report are fixed. We are left with only 3 test failures related to ordered/unordered comparisons. (In reply to Józef Kucia from comment #13) > Thanks! I can confirm that vkd3d test failures reported in this bug report > are fixed. We are left with only 3 test failures related to > ordered/unordered comparisons. Is there a bug for those? (In reply to Lionel Landwerlin from comment #14) > Is there a bug for those? https://bugs.freedesktop.org/show_bug.cgi?id=109249 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.