Bug 109725

Summary:	piglit.spec.arb_cull_distance regressions
Product:	Mesa	Reporter:	Mark Janes <mark.a.janes>
Component:	Drivers/DRI/i965	Assignee:	Jason Ekstrand <jason>
Status:	RESOLVED DUPLICATE	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	apinheiro
Version:	git	Keywords:	bisected, regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Mark Janes 2019-02-21 16:21:26 UTC

The following tests regressed:

piglit.spec.arb_cull_distance.basic-cull-4
piglit.spec.arb_cull_distance.basic-cull-2
piglit.spec.arb_cull_distance.basic-cull-3
piglit.spec.arb_cull_distance.basic-cull-1
piglit.spec.arb_cull_distance.vs-cull-distance-vertex-inside-cull-volume
piglit.spec.arb_cull_distance.vs-cull-distance-vertex-outside-cull-volume
piglit.spec.arb_cull_distance.fs-cull-distance-interpolated
piglit.spec.arb_cull_distance.vs-cull-distance-vertex-on-plane
KHR-GL33.cull_distance.functional
KHR-GL46.cull_distance.functional

Bisected to:

4e69fba534e7377f3bc6c40c73e6bc5c23437d4e
Author:     Jason Ekstrand <jason@jlekstrand.net>

nir: Rewrite lower_clip_cull_distance_arrays to do a lot less lowering

Instead of going to all the work of to combine them into one array, just
make two arrays and use location_frac to colocate them within CLIP0.
Then the back-end can sort things out and stack them on top of each
other.  Thanks to ef99f4c8, we also don't need to set compact anymore.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Comment 1 Lionel Landwerlin 2019-02-21 16:23:12 UTC


*** This bug has been marked as a duplicate of bug 109717 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.