| Summary: | enable storageBuffer16BitAccess feature in radv for SI and CIK | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | nihui <shuizhuyuanluo> |
| Component: | Drivers/Vulkan/radeon | Assignee: | mesa-dev |
| Status: | RESOLVED MOVED | QA Contact: | mesa-dev |
| Severity: | enhancement | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Where can I find this benchmark? (In reply to Samuel Pitoiset from comment #1) > Where can I find this benchmark? Hi The benchmark is the benchncnn program in repo https://github.com/Tencent/ncnn We should be able to enable it but I have to deal with some failures first. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/857. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
the VK_KHR_16bit_storage extension is enabled but all features are reported as FALSE for SI and CIK. I found those features are only enabled with VI+ in mesa/src/amd/vulkan/radv_device.c as contrast, the amdvlk driver support them. 16bit storage support is important for reducing shader bandwidth and gaining speed boost. (found 20%~50% speedup with the ncnn vulkan nerual network benchmark) please consider implementing storageBuffer16BitAccess feature for SI and CIK. Thanks! case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES: { VkPhysicalDevice16BitStorageFeatures *features = (VkPhysicalDevice16BitStorageFeatures*)ext; bool enabled = pdevice->rad_info.chip_class >= VI; features->storageBuffer16BitAccess = enabled; features->uniformAndStorageBuffer16BitAccess = enabled; features->storagePushConstant16 = enabled; features->storageInputOutput16 = enabled && HAVE_LLVM >= 0x900; break; }