Bug 110268 - enable storageBuffer16BitAccess feature in radv for SI and CIK
Summary: enable storageBuffer16BitAccess feature in radv for SI and CIK
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Vulkan/radeon (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-28 04:57 UTC by nihui
Modified: 2019-09-18 19:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nihui 2019-03-28 04:57:43 UTC
the VK_KHR_16bit_storage extension is enabled but all features are reported as FALSE for SI and CIK.

I found those features are only enabled with VI+ in mesa/src/amd/vulkan/radv_device.c

as contrast, the amdvlk driver support them.

16bit storage support is important for reducing shader bandwidth and gaining speed boost. (found 20%~50% speedup with the ncnn vulkan nerual network benchmark)

please consider implementing storageBuffer16BitAccess feature for SI and CIK.

Thanks!


		case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES: {
			VkPhysicalDevice16BitStorageFeatures *features =
			    (VkPhysicalDevice16BitStorageFeatures*)ext;
			bool enabled = pdevice->rad_info.chip_class >= VI;
			features->storageBuffer16BitAccess = enabled;
			features->uniformAndStorageBuffer16BitAccess = enabled;
			features->storagePushConstant16 = enabled;
			features->storageInputOutput16 = enabled && HAVE_LLVM >= 0x900;
			break;
		}
Comment 1 Samuel Pitoiset 2019-03-28 07:53:26 UTC
Where can I find this benchmark?
Comment 2 nihui 2019-03-28 08:46:36 UTC
(In reply to Samuel Pitoiset from comment #1)
> Where can I find this benchmark?

Hi

The benchmark is the benchncnn program in repo
https://github.com/Tencent/ncnn
Comment 3 Samuel Pitoiset 2019-03-29 08:18:25 UTC
We should be able to enable it but I have to deal with some failures first.
Comment 4 GitLab Migration User 2019-09-18 19:55:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/857.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.