|Summary:||SKL. Textures are flickering in SuperTuxKart|
|Component:||Drivers/DRI/i965||Assignee:||Intel 3D Bugs Mailing List <intel-3d-bugs>|
|Status:||RESOLVED FIXED||QA Contact:||Intel 3D Bugs Mailing List <intel-3d-bugs>|
|Priority:||medium||CC:||asdfghrbljzmkd, danylo.piliaiev, denys.kostin, deveee, horst, mark.a.janes|
|i915 platform:||i915 features:|
Description Denis 2019-04-17 13:23:05 UTC
Original report and attachments were added by Mark here: https://bugs.freedesktop.org/show_bug.cgi?id=110395 Short description (full history can be found also there, in original ticket): When I run supertuxcart on skl, I see lots of flickering. See attached video. Curiously, I had to take a video of it with my phone, because the flickering *stops* when I enable gnome's screen recording (ctrl-alt-shift-r). The non-flickering video is also attached for reference. Danylo's patch has no affect on this behavior.
Comment 1 Denis 2019-08-08 15:05:46 UTC
Hi Mark, Horst Schirmeier, may I ask you to re-check please this issue on SKL? We couldn't reproduce it from our side even that time when it flickered for you, so would be great to be sure that fix works. commit bc612536eb2f0f77725103e53077ad5a28036ac3 (HEAD -> master, origin/master, origin/HEAD) Author: Jason Ekstrand <firstname.lastname@example.org> Date: Wed Jul 31 10:42:24 2019 -0500 anv: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109630 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111267 Cc: email@example.com Reviewed-by: Kenneth Graunke <firstname.lastname@example.org> Tested mesa-master with the commit on my CFL (checked on attached apitrace). Works without flickers now.
Comment 2 Denis 2019-08-08 15:08:41 UTC
I am sorry, previous comment was related to ANV fix. Current issue (for i965) should be fixed with this one: commit b8842bc3128a255677a1a8ea5207df46f8e54a04 Author: Danylo Piliaiev <email@example.com> Date: Thu Aug 1 13:57:14 2019 +0300 i965: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110395 Suggested-by: Jason Ekstrand <firstname.lastname@example.org> Signed-off-by: Danylo Piliaiev <email@example.com> Reviewed-by: Kenneth Graunke <firstname.lastname@example.org> Cc: email@example.com
Comment 3 Mark Janes 2019-08-10 02:25:25 UTC
I can verify that the flickering is fixed by b8842bc3128a255677a1a8ea5207df46f8e54a04. Would it be possible to write a piglit test to detect this issue? since several titles were broken...
Comment 4 Denis 2019-08-12 11:29:07 UTC
thanks for checking! We are working on test into piglit
Comment 5 QwertyChouskie 2019-09-06 01:19:34 UTC
Did this commit make it into 19.2 before it was branched? Also can this be back-ported to 19.1 and below? The bug seems to have been around for a while: https://github.com/supertuxkart/stk-code/issues/3505 Thanks!
Comment 6 Mark Janes 2019-09-06 16:36:09 UTC
Yes, this commit is in the upcoming 19.2 release.
Comment 7 Mark Janes 2019-09-09 20:47:54 UTC
*** Bug 110395 has been marked as a duplicate of this bug. ***