| Summary: | SKL. Textures are flickering in SuperTuxKart | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Denis <denys.kostin> |
| Component: | Drivers/DRI/i965 | Assignee: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | asdfghrbljzmkd, danylo.piliaiev, denys.kostin, deveee, horst, mark.a.janes |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=110395 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Denis
2019-04-17 13:23:05 UTC
Hi Mark, Horst Schirmeier, may I ask you to re-check please this issue on SKL? We couldn't reproduce it from our side even that time when it flickered for you, so would be great to be sure that fix works. commit bc612536eb2f0f77725103e53077ad5a28036ac3 (HEAD -> master, origin/master, origin/HEAD) Author: Jason Ekstrand <jason@jlekstrand.net> Date: Wed Jul 31 10:42:24 2019 -0500 anv: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109630 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111267 Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Tested mesa-master with the commit on my CFL (checked on attached apitrace). Works without flickers now. I am sorry, previous comment was related to ANV fix. Current issue (for i965) should be fixed with this one: commit b8842bc3128a255677a1a8ea5207df46f8e54a04 Author: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Date: Thu Aug 1 13:57:14 2019 +0300 i965: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110395 Suggested-by: Jason Ekstrand <jason@jlekstrand.net> Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org I can verify that the flickering is fixed by b8842bc3128a255677a1a8ea5207df46f8e54a04. Would it be possible to write a piglit test to detect this issue? since several titles were broken... thanks for checking! We are working on test into piglit Did this commit make it into 19.2 before it was branched? Also can this be back-ported to 19.1 and below? The bug seems to have been around for a while: https://github.com/supertuxkart/stk-code/issues/3505 Thanks! Yes, this commit is in the upcoming 19.2 release. *** Bug 110395 has been marked as a duplicate of this bug. *** *** Bug 110395 has been marked as a duplicate of this bug. *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.