Bug 1105

Summary: cw breaks CopyArea for non-redir dst, redir src
Product: xorg Reporter: Eric Anholt <eric>
Component: Server/GeneralAssignee: Eric Anholt <eric>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: high CC: kem
Version: git   
Hardware: x86 (IA32)   
OS: FreeBSD   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 351    
Attachments:
Description Flags
Removes the cheap funcs system, which should fix CopyArea none

Description Eric Anholt 2004-08-16 17:27:53 UTC 
The cheap funcs optimization brought over from mibstore breaks CopyArea.  The
problem is that if the destination is non-redirected, ops don't get wrapped, so
use of a redirected source results in copying from the screen instead of the
backing pixmap.  Reported by deronj.

I think the solution is to always wrap ops and get rid of the cheap funcs system
entirely.
Comment 1 Eric Anholt 2004-08-17 15:13:46 UTC 
Created attachment 661 [details] [review]
Removes the cheap funcs system, which should fix CopyArea

This should fix it.  I've tested in a limited manner with xcompmgr, just that
things still work.  I haven't tested CopyArea.
Comment 2 Kevin E. Martin 2004-08-17 15:37:51 UTC 
Potential blocker bug.  Needs testing to ensure that it doesn't break anything else.
Comment 3 Deron Johnson 2004-08-17 16:43:23 UTC 
This patch fixes the CopyArea problem for LG3D.
Comment 4 Kevin E. Martin 2004-08-18 14:11:26 UTC 
Patch discussed on today's release wranglers call and accepted.
Patch tested and applied.
Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.