Bug 1105 - cw breaks CopyArea for non-redir dst, redir src
Summary: cw breaks CopyArea for non-redir dst, redir src
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) FreeBSD
: high critical
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency tree / graph
 
Reported: 2004-08-16 17:27 UTC by Eric Anholt
Modified: 2004-08-17 21:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Removes the cheap funcs system, which should fix CopyArea (7.72 KB, patch)
2004-08-17 15:13 UTC, Eric Anholt 		no flags Details | Splinter Review
View All

Description Eric Anholt 2004-08-16 17:27:53 UTC 
The cheap funcs optimization brought over from mibstore breaks CopyArea.  The
problem is that if the destination is non-redirected, ops don't get wrapped, so
use of a redirected source results in copying from the screen instead of the
backing pixmap.  Reported by deronj.

I think the solution is to always wrap ops and get rid of the cheap funcs system
entirely.
Comment 1 Eric Anholt 2004-08-17 15:13:46 UTC 
Created attachment 661 [details] [review]
Removes the cheap funcs system, which should fix CopyArea

This should fix it.  I've tested in a limited manner with xcompmgr, just that
things still work.  I haven't tested CopyArea.
Comment 2 Kevin E. Martin 2004-08-17 15:37:51 UTC 
Potential blocker bug.  Needs testing to ensure that it doesn't break anything else.
Comment 3 Deron Johnson 2004-08-17 16:43:23 UTC 
This patch fixes the CopyArea problem for LG3D.
Comment 4 Kevin E. Martin 2004-08-18 14:11:26 UTC 
Patch discussed on today's release wranglers call and accepted.
Patch tested and applied.
Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.