| Summary: | [BRW] WRC 5 asserts with gallium nine and iris. | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Illia Iorin <illia.iorin> |
| Component: | Gallium/StateTracker/galliumnine | Assignee: | mesa-dev |
| Status: | RESOLVED MOVED | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | medium | CC: | fdsfgs, illia.iorin, matias.nicolas.zc, nanleychery |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Illia Iorin
2019-07-16 13:45:22 UTC
Is the tiling of the surface X-tiled? My guess is that this commit enables CCS for X-tiled images used for display. This now causes us to fast-clear the image in NineSurface9_ctor. When resource_get_handle is called (from D3DWindowBuffer_create?) we're not flushing/resolving as expected when PIPE_HANDLE_USAGE_EXPLICIT_FLUSH flag is passed in as an argument. Does adding the following in iris_resource_get_handle fix it? if ((usage & PIPE_HANDLE_USAGE_EXPLICIT_FLUSH) && res->aux.usage != 0) iris_flush_resource(ctx, res); Yes, tilling is X-tiled. This flush fixes the assertion failure but it didn't fix the game being stuck. I’ll try to make a trace. *** Bug 111162 has been marked as a duplicate of this bug. *** (In reply to Illia Iorin from comment #2) > Yes, tilling is X-tiled. I created a merge request for this issue here: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1371 Please let me know if it fixes the issue. > This flush fixes the assertion failure but it didn't fix the game being > stuck. I’ll try to make a trace. I think we should file another bug for the game being stuck. It's not clear that the two are related. > I created a merge request for this issue here:
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1371
>
> Please let me know if it fixes the issue.
This mr fixes the issue. I tried to put the flash exact after nine_context_clear_render_target in NineSurface9_ctor and it fixes the issue too.
(In reply to Nanley Chery from comment #3) > *** Bug 111162 has been marked as a duplicate of this bug. *** Sorry, i didn't find this bug before posting. The merge request also fixes the problem for me (In reply to Matías Zúñiga from comment #6) > (In reply to Nanley Chery from comment #3) > > *** Bug 111162 has been marked as a duplicate of this bug. *** > > Sorry, i didn't find this bug before posting. > > The merge request also fixes the problem for me No problem. I just updated the MR to fix the issue in iris. Please let me know if it still helps. I'm not sure what issues are remaining in gallium nine (if any). (In reply to Nanley Chery from comment #7) > (In reply to Matías Zúñiga from comment #6) > > (In reply to Nanley Chery from comment #3) > > > *** Bug 111162 has been marked as a duplicate of this bug. *** > > > > Sorry, i didn't find this bug before posting. > > > > The merge request also fixes the problem for me > > No problem. I just updated the MR to fix the issue in iris. Please let me > know if it still helps. Yeah, still working > I'm not sure what issues are remaining in gallium nine (if any). League Of Legends didnt work for me (it works with other Gallium drivers), but I cant get any information on were it crashes (to make League work, a patched version of wine is needed. that patch makes core-dumps unreadable, so i can't get a backtrace). I will open a report when i get useful information (In reply to Nanley Chery from comment #7) > I just updated the MR to fix the issue in iris. Please let me know if it still helps. Updated MR fixes assert in WRC5. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/128. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.