| Summary: | XGetMotionEvents got broken in codestyle commit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Olivier Blin <freedesktop> | ||||
| Component: | Lib/Xlib | Assignee: | Magnus Kessler <Magnus.Kessler> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | bugzilla, sndirsch, tilman | ||||
| Version: | unspecified | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Olivier Blin
2007-06-10 14:06:54 UTC
Created attachment 10243 [details] [review] fix XGetMotionEvents arguments order The following patch fixes it. (how do I attach a brown paper bag? :-) For the record, it breaks gdk+, and especially gimp. The initial bug report was here: http://bugzilla.gnome.org/show_bug.cgi?id=445376 Magnus, could you fix this please in git? Thanks. Not sure, if Magnus has git commit rights. Tilman, could you help here? I checked in the fix... Dang, I don't think I made sure that the argument order in the header matches the one in the C files :( Thanks. BTW, I did have a closer look at all the hunks in the "K&R --> ANSI" patch, but couldn't find any other broken hunk. Hopefully I didn't overlook any. I only noticed the bug report now. Sorry for the delay. Thanks to all who helped track this down and fix, and apologies to anyone who got stung by this oversight (/me accepts brown paper bag from Olivier :) ). I have looked at the K&R to ANSI patch again and believe there are no further problems. More eyes welcome. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.