Bug 11222 - XGetMotionEvents got broken in codestyle commit
Summary: XGetMotionEvents got broken in codestyle commit
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Magnus Kessler
QA Contact: Xorg Project Team
Depends on:
Reported: 2007-06-10 14:06 UTC by Olivier Blin
Modified: 2007-06-11 15:27 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

fix XGetMotionEvents arguments order (405 bytes, patch)
2007-06-10 14:10 UTC, Olivier Blin
no flags Details | Splinter Review

Description Olivier Blin 2007-06-10 14:06:54 UTC
The XGetMotionEvents prototype has been wrongly modified in commit a48386ce6b5f8fd2d9dc11a966c9bf5da59f3831, the argument orders does not match the prototype from Xlib.h anymore.
Comment 1 Olivier Blin 2007-06-10 14:10:01 UTC
Created attachment 10243 [details] [review]
fix XGetMotionEvents arguments order

The following patch fixes it.
(how do I attach a brown paper bag? :-)
Comment 2 Olivier Blin 2007-06-11 00:09:08 UTC
For the record, it breaks gdk+, and especially gimp. The initial bug report was here: http://bugzilla.gnome.org/show_bug.cgi?id=445376
Comment 3 Stefan Dirsch 2007-06-11 00:46:24 UTC
Magnus, could you fix this please in git? Thanks.
Comment 4 Stefan Dirsch 2007-06-11 00:55:34 UTC
Not sure, if Magnus has git commit rights. Tilman, could you help here?
Comment 5 Dave Airlie 2007-06-11 01:33:18 UTC
I checked in the fix...
Comment 6 Tilman Sauerbeck 2007-06-11 08:20:17 UTC
Dang, I don't think I made sure that the argument order in the header matches the one in the C files :(
Comment 7 Stefan Dirsch 2007-06-11 08:40:38 UTC
Comment 8 Stefan Dirsch 2007-06-11 08:58:43 UTC
BTW, I did have a closer look at all the hunks in the "K&R --> ANSI" patch, but couldn't find any other broken hunk. Hopefully I didn't overlook any.
Comment 9 Magnus Kessler 2007-06-11 15:27:36 UTC
I only noticed the bug report now. Sorry for the delay. Thanks to all who helped track this down and fix, and apologies to anyone who got stung by this oversight (/me accepts brown paper bag from Olivier :) ). I have looked at the K&R to ANSI patch again and believe there are no further problems. More eyes welcome.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.