| Summary: | crash when Exa:MarkSync function is set to NULL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Dodji Seketeli <dodji> | ||||||
| Component: | Server/Acceleration/EXA | Assignee: | Xorg Project Team <xorg-team> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | ||||||||
| Version: | 7.2 (2007.02) | ||||||||
| Hardware: | Other | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Dodji Seketeli
2007-06-11 00:44:50 UTC
Created attachment 10248 [details] [review] fixes a crash when the Exa:WaitSync function pointer is set to NULL See exa.h: 'WaitMarker() is required of all drivers.' That said, a better solution might be for exaDriverInit to check this and fail if it's missing. Okay. I have seen that it was required, but I don't think that crashing is an acceptable answer anyway. I like your proposal of checking that in the exa initialization. Would you accept a patch for that ? If yes, then could we re-open the bug or open another one until the patch is applied ? Thanks. An exaDriverInit patch should be acceptable. Okay, thanks. I will work on it then. Created attachment 10755 [details] [review] quickly check if some mandatory exa driver hooks are missing This patch just quickly checks during exa init if some of the mandatory driver hooks are missing. Pushed with cosmetic fixups as commit 5657fb065cc79ba3ca5a836f45637ba9894f9abf, thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.