Bug 11391

Summary:	Wrong NULL-Check order/deref before null check
Product:	xorg	Reporter:	Roland "Test-tools" Bär <roland>
Component:	App/compiz	Assignee:	David Reveman <reveman>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	trivial
Priority:	lowest
Version:	git
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Roland "Test-tools" Bär 2007-06-27 05:09:17 UTC

compiz/kde/window-decorator/window.cpp function KWD::Window::updateProperty (void)
line 1342.
At line 1360:   mDecor->borders (maxExtents.left, maxExtents.right,
 "mDecor" gets derefenced
Later at line 1382: 		if (mDecor)
Either mDecor should be NULL-checked before first dereference at line 1360,
or that later NULL-check is unnecessary.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.