Bug 11391 - Wrong NULL-Check order/deref before null check
Summary: Wrong NULL-Check order/deref before null check
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/compiz (show other bugs)
Version: git
Hardware: All All
: lowest trivial
Assignee: David Reveman
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-27 05:09 UTC by Roland "Test-tools" Bär
Modified: 2007-07-05 14:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Roland "Test-tools" Bär 2007-06-27 05:09:17 UTC
compiz/kde/window-decorator/window.cpp function KWD::Window::updateProperty (void)
line 1342.
At line 1360:   mDecor->borders (maxExtents.left, maxExtents.right,
 "mDecor" gets derefenced
Later at line 1382: 		if (mDecor)
Either mDecor should be NULL-checked before first dereference at line 1360,
or that later NULL-check is unnecessary.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.