Summary: | Make KPDL tuneable | ||
---|---|---|---|
Product: | xkeyboard-config | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
Component: | General | Assignee: | xkb |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 8852 | ||
Attachments: |
Proposed patch
Proposed patch |
Description
Nicolas Mailhot
2007-07-15 06:11:00 UTC
Created attachment 10737 [details] [review] Proposed patch Created attachment 10742 [details] [review] Proposed patch Add new file to Makefiles so it's actually installed Dynamic kpdl override (from the gnome applet) does not seem to work, so I'm probably missing some magic somewhere (or rawhide is more broken as usual) But the converted layouts just work, so the basic patch is sane Yes, you missed a part in rules/base.o_s.part. But I have added it myself. I actually like your idea, so I've committed it. The only doubt I have whether it is worth separate file symbols/kpdl or wouldn't it be better as part of symbols/keypad - like keypad(kpdl_comma), keypad(kpdl_dot) etc. Anyway, the XKB options would still be kpdl:... What do you think? I actually started adding stuff in keypad, then noticed keypad(dot) and keypad(comma). I didn't like their naming because it was colliding with the full keypad layouts. As long as the naming makes very clear we're only changing kpdl, I don't care. Users may prefer the shorter naming though. BTW, it may be my idea, but somehow I only get inspiration after getting prodded by users and having to write pages on why the current kpdl behaves like it does ;) I'm not seing kpdl on http://webcvs.freedesktop.org/xkeyboard-config/xkeyboard-config/symbols/ so maybe the new file was created with the worng permissions Sorry, my fault, forgot to add it |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.