Bug 11611 - Make KPDL tuneable
Summary: Make KPDL tuneable
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 8852
  Show dependency treegraph
 
Reported: 2007-07-15 06:11 UTC by Nicolas Mailhot
Modified: 2007-07-16 07:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch (25.12 KB, patch)
2007-07-15 06:11 UTC, Nicolas Mailhot
Details | Splinter Review
Proposed patch (26.78 KB, patch)
2007-07-15 08:38 UTC, Nicolas Mailhot
Details | Splinter Review

Description Nicolas Mailhot 2007-07-15 06:11:00 UTC
It seems OpenOffice.org now only understands comma as decimal separator in comma countries

So in addition to users that really want kpdl to be a dot (because that's what's printed on their hardware) we now have a large class of users that really want it to be a comma.

The attached patch lets users choose their poison and define the kpdl behaviour. It's more complete than the previous keypad(dot) and keypad(comma) (adds four-level keypads, momayyez for arabic/persian coutries), and exposes a tuneable to users

The option was moved to its own file to avoid confusion with full-keypad layouts
Comment 1 Nicolas Mailhot 2007-07-15 06:11:36 UTC
Created attachment 10737 [details] [review]
Proposed patch
Comment 2 Nicolas Mailhot 2007-07-15 08:38:31 UTC
Created attachment 10742 [details] [review]
Proposed patch

Add new file to Makefiles so it's actually installed
Comment 3 Nicolas Mailhot 2007-07-15 08:40:11 UTC
Dynamic kpdl override (from the gnome applet) does not seem to work, so I'm probably missing some magic somewhere (or rawhide is more broken as usual)

But the converted layouts just work, so the basic patch is sane
Comment 4 Sergey V. Udaltsov 2007-07-15 15:09:29 UTC
Yes, you missed a part in rules/base.o_s.part. But I have added it myself. I actually like your idea, so I've committed it. The only doubt I have whether it is worth separate file symbols/kpdl or wouldn't it be better as part of symbols/keypad - like keypad(kpdl_comma), keypad(kpdl_dot) etc. Anyway, the XKB options would still be kpdl:...  What do you think?
Comment 5 Nicolas Mailhot 2007-07-15 23:14:21 UTC
I actually started adding stuff in keypad, then noticed keypad(dot) and keypad(comma). I didn't like their naming because it was colliding with the full keypad layouts.

As long as the naming makes very clear we're only changing kpdl, I don't care. Users may prefer the shorter naming though.

BTW, it may be my idea, but somehow I only get inspiration after getting prodded by users and having to write pages on why the current kpdl behaves like it does ;)
Comment 6 Nicolas Mailhot 2007-07-16 06:56:27 UTC
I'm not seing kpdl on http://webcvs.freedesktop.org/xkeyboard-config/xkeyboard-config/symbols/ so maybe the new file was created with the worng permissions
Comment 7 Sergey V. Udaltsov 2007-07-16 07:00:33 UTC
Sorry, my fault, forgot to add it


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.