Bug 11835

Created attachment 10984 [details] [review]
Patch for adding Sony Ericsson K800i to 10-usb-music-players.fdi

submitted an adopted and  cleaned-up version of the patch to hal-info.

My Sony Ericsson K800i has a different product id:
key="@storage.originating_device:usb.product_id" int="0xe039"
rather than "0xd039".

As far as I can tell, a new <match> section has to be added even though it is the same phone - but maybe there is a better way of doing this.

As well as adding this new product id, I think there should also be two other important <append> keys added:

<append key="portable_audio_player.output_formats" type="strlist">audio/mpeg</append> - The main format of the music player is MP3.
<append key="portable_audio_player.audio_folders" type="strlist">Music/</append> - This is the directory where music should be stored on the device so the phone's music player can find it.

Created attachment 16508 [details] [review]
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders

Created attachment 16509 [details] [review]
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders

I still don't know if this is the correct patch - I'm still learning. The line numbers may not be correct as I can't find where to download the latest version of the file. Hope this makes sense.

Commited an adopted version of your patch. Check out:

http://cgit.freedesktop.org/~dkukawka/hal-info/log/

commit 1fba2e4bd374035fc884edc9c929a04d48bbf6a6
Author: Danny Kukawka <danny.kukawka@web.de>
Date:   Fri Aug 14 16:16:48 2009 +0200

    add another version of a SonyEricsson K800i as music player

    Added an adapted version of a patch from fd.o#11835, contributed
    by Per Thomas Jahr <perja@ifi.uio.no>, to add another version of
    a SonyEricsson K800i as USB music player.