Bug 11835 - [PATCH] Support Sony Ericsson K800i in 10-usb-music-players.fdi
Summary: [PATCH] Support Sony Ericsson K800i in 10-usb-music-players.fdi
Status: RESOLVED FIXED
Alias: None
Product: hal
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Danny Kukawka
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-03 13:16 UTC by Per Thomas Jahr
Modified: 2009-08-14 07:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for adding Sony Ericsson K800i to 10-usb-music-players.fdi (3.60 KB, patch)
2007-08-03 13:18 UTC, Per Thomas Jahr
Details | Splinter Review
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders (1.92 KB, patch)
2008-05-13 09:34 UTC, Damian Moore
Details | Splinter Review
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders (3.01 KB, patch)
2008-05-13 09:45 UTC, Damian Moore
Details | Splinter Review

Description Per Thomas Jahr 2007-08-03 13:16:41 UTC
Here is a rather complete list of supported file formats for the Sony Ericsson K800i mobile phone. Please add this to the 10-usb-music-players.fdi file.
Comment 1 Per Thomas Jahr 2007-08-03 13:18:57 UTC
Created attachment 10984 [details] [review]
Patch for adding Sony Ericsson K800i to 10-usb-music-players.fdi
Comment 2 Danny Kukawka 2007-08-28 13:43:58 UTC
submitted an adopted and  cleaned-up version of the patch to hal-info.
Comment 3 Damian Moore 2008-05-06 11:24:43 UTC
My Sony Ericsson K800i has a different product id:
key="@storage.originating_device:usb.product_id" int="0xe039"
rather than "0xd039".

As far as I can tell, a new <match> section has to be added even though it is the same phone - but maybe there is a better way of doing this.

As well as adding this new product id, I think there should also be two other important <append> keys added:

<append key="portable_audio_player.output_formats" type="strlist">audio/mpeg</append> - The main format of the music player is MP3.
<append key="portable_audio_player.audio_folders" type="strlist">Music/</append> - This is the directory where music should be stored on the device so the phone's music player can find it.
Comment 4 Damian Moore 2008-05-13 09:34:01 UTC
Created attachment 16508 [details] [review]
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders
Comment 5 Damian Moore 2008-05-13 09:45:15 UTC
Created attachment 16509 [details] [review]
Patch to add support for the alternative product_id and also fix the existing entry's output_formats and audio_folders

I still don't know if this is the correct patch - I'm still learning. The line numbers may not be correct as I can't find where to download the latest version of the file. Hope this makes sense.
Comment 6 Danny Kukawka 2009-08-14 07:20:01 UTC
Commited an adopted version of your patch. Check out:

http://cgit.freedesktop.org/~dkukawka/hal-info/log/

commit 1fba2e4bd374035fc884edc9c929a04d48bbf6a6
Author: Danny Kukawka <danny.kukawka@web.de>
Date:   Fri Aug 14 16:16:48 2009 +0200

    add another version of a SonyEricsson K800i as music player

    Added an adapted version of a patch from fd.o#11835, contributed
    by Per Thomas Jahr <perja@ifi.uio.no>, to add another version of
    a SonyEricsson K800i as USB music player.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.