| Summary: | gabble_connection_connected_olpc could just be attached to status-changed | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | gabble | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | lowest | CC: | dafydd.harries |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Remove TpBaseConnection.connected callback. | ||
|
Description
Simon McVittie
2007-08-17 09:45:12 UTC
Created attachment 48477 [details] [review] Remove TpBaseConnection.connected callback. This OLPC-specific function can just be called from the ::status-changed signal handler. I've called it at the end of that function because the 'connected' vfunc is called just after ::status-changed is emitted, so this shouldn't change the order of operations in the OLPC code. I'm not sure to understand why this is important to change, but should be armless and less code is always better :) Review of attachment 48477 [details] [review]: +1 Merged to master, will be in 0.13.4. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.