Bug 12041 - gabble_connection_connected_olpc could just be attached to status-changed
Summary: gabble_connection_connected_olpc could just be attached to status-changed
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: lowest minor
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-08-17 09:45 UTC by Simon McVittie
Modified: 2011-08-03 02:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Remove TpBaseConnection.connected callback. (2.59 KB, patch)
2011-06-27 10:49 UTC, Will Thompson 		Details | Splinter Review
View All

Description Simon McVittie 2007-08-17 09:45:12 UTC 
gabble_connection_connected_olpc could just be attached to status-changed, probably.
Comment 1 Will Thompson 2011-06-27 10:49:55 UTC 
Created attachment 48477 [details] [review]
Remove TpBaseConnection.connected callback.

This OLPC-specific function can just be called from the ::status-changed
signal handler. I've called it at the end of that function because the
'connected' vfunc is called just after ::status-changed is emitted, so
this shouldn't change the order of operations in the OLPC code.
Comment 2 Xavier Claessens 2011-08-02 04:29:58 UTC 
I'm not sure to understand why this is important to change, but should be armless and less code is always better :)
Comment 3 Xavier Claessens 2011-08-02 04:30:23 UTC 
Review of attachment 48477 [details] [review]:

+1
Comment 4 Will Thompson 2011-08-03 02:41:32 UTC 
Merged to master, will be in 0.13.4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.