| Summary: | diNovo Edge support | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Tim Boundy <gigaplex> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://bugs.gentoo.org/show_bug.cgi?id=195580 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
diNovo Edge support
updated patch to follow rules |
||
|
Description
Tim Boundy
2007-10-12 01:52:29 UTC
Created attachment 12006 [details] [review] diNovo Edge support Basic diNovo Edge support. Tim, could you please update your patch following the rules described here: http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules. In particular - regarding base.xml.in and inet(media_common). Also, if you don't mind, could you please prefix the model name with "logi" so it would be clear it is is from Logitech. Thanks Created attachment 12007 [details] [review] updated patch to follow rules Attached is an updated patch to follow the rules that were mentioned. The rules state that rules/base.lists.part is to have $inetkbds modified, but I had to modify both the rules/base.lists.part file and the rules/base file to get the changes to take. Can you clarify the purpose of the rules/base.lists.part file when all of its contents are in rules/base ? Since my original patch was simply a copy/paste of the original dinovo model and my copy didn't follow the naming convention, I renamed dinovo to logidinovo. That patch really looks much better. Answering your question, the file rules/base is composed during the build process from several parts. One of them is base.lists.part. Did you run "make" after you modified base.lists.part? (In reply to comment #4) > That patch really looks much better. > > Answering your question, the file rules/base is composed during the build > process from several parts. One of them is base.lists.part. Did you run "make" > after you modified base.lists.part? > I used the ebuild provided by Gentoo to build and install, I did not explicitly run make myself. I'll have a look at the build script later. If rules/base is generated during the build process, why is it included in the tarball at http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-1.1.tar.bz2 ? > I used the ebuild provided by Gentoo to build and install, I did not explicitly
> run make myself. I'll have a look at the build script later. If rules/base is
> generated during the build process, why is it included in the tarball at
> http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-1.1.tar.bz2 ?
For historical reasons, mainly. But you're right - I'll consider removing it from the source tarball.
diNovo code is committed, thanks a bunch! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.