Bug 12789 - diNovo Edge support
Summary: diNovo Edge support
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL: http://bugs.gentoo.org/show_bug.cgi?i...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-12 01:52 UTC by Tim Boundy
Modified: 2007-10-13 08:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
diNovo Edge support (2.31 KB, patch)
2007-10-12 01:53 UTC, Tim Boundy
Details | Splinter Review
updated patch to follow rules (2.94 KB, patch)
2007-10-12 03:13 UTC, Tim Boundy
Details | Splinter Review

Description Tim Boundy 2007-10-12 01:52:29 UTC
Using the dinovo model on the Logitech diNovo Edge, most buttons work except for the volume slider. When using the geniuscomfty2 model (my previous keyboard) the volume slider functions but all media buttons do not. I have created a patch using the correct keycodes for the newer model dinovoedge and submitted to the Gentoo bug list, and was told to forward upstream.
Comment 1 Tim Boundy 2007-10-12 01:53:23 UTC
Created attachment 12006 [details] [review]
diNovo Edge support

Basic diNovo Edge support.
Comment 2 Sergey V. Udaltsov 2007-10-12 02:01:59 UTC
Tim, could you please update your patch following the rules described here: http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules. In particular - regarding base.xml.in and inet(media_common). Also, if you don't mind, could you please prefix the model name with "logi" so it would be clear it is is from Logitech.

Thanks
Comment 3 Tim Boundy 2007-10-12 03:13:59 UTC
Created attachment 12007 [details] [review]
updated patch to follow rules

Attached is an updated patch to follow the rules that were mentioned. The rules state that rules/base.lists.part is to have $inetkbds modified, but I had to modify both the rules/base.lists.part file and the rules/base file to get the changes to take. Can you clarify the purpose of the rules/base.lists.part file when all of its contents are in rules/base ?

Since my original patch was simply a copy/paste of the original dinovo model and my copy didn't follow the naming convention, I renamed dinovo to logidinovo.
Comment 4 Sergey V. Udaltsov 2007-10-12 03:29:02 UTC
That patch really looks much better.

Answering your question, the file rules/base is composed during the build process from several parts. One of them is base.lists.part. Did you run "make" after you modified base.lists.part?
Comment 5 Tim Boundy 2007-10-12 03:40:14 UTC
(In reply to comment #4)
> That patch really looks much better.
> 
> Answering your question, the file rules/base is composed during the build
> process from several parts. One of them is base.lists.part. Did you run "make"
> after you modified base.lists.part?
> 

I used the ebuild provided by Gentoo to build and install, I did not explicitly run make myself. I'll have a look at the build script later. If rules/base is generated during the build process, why is it included in the tarball at http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-1.1.tar.bz2 ?
Comment 6 Sergey V. Udaltsov 2007-10-12 03:44:08 UTC
> I used the ebuild provided by Gentoo to build and install, I did not explicitly
> run make myself. I'll have a look at the build script later. If rules/base is
> generated during the build process, why is it included in the tarball at
> http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-1.1.tar.bz2 ?

For historical reasons, mainly. But you're right - I'll consider removing it from the source tarball.
Comment 7 Sergey V. Udaltsov 2007-10-13 08:42:57 UTC
diNovo code is committed, thanks a bunch!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.