Bug 12876

Summary: GL/glx/glxglcore.c uses num_vis but never assigns it
Product: xorg Reporter: Samuel Thibault <samuel.thibault>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Samuel Thibault 2007-10-21 05:23:03 UTC 
in GL/glx/glxglcore.c, one can read in the __glXMesaScreenDestroy function that the num_vis field is used, but it is never set in any other function. It should probably be set to i at the end of the createMesaVisuals function. Also, in createMesaVisuals, are we sure that the j loop always find a visual? If yes, an assertion would probably be good, else there should be a continue; statement.
Comment 1 Michel Dänzer 2009-09-01 02:17:59 UTC 
The GLX code has been refactored, is this still an issue?
Comment 2 Samuel Thibault 2009-09-01 04:01:21 UTC 
Well, I can't find the code any more so I guess it just disappeared.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.