| Summary: | Patch to support Nokia 6300 as a music device | ||
|---|---|---|---|
| Product: | hal | Reporter: | Adam Williamson <adamw> |
| Component: | hal-info | Assignee: | Danny Kukawka <danny.kukawka> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch to support Nokia 6300 as a music player
Patch to support Nokia 6300 as a music player |
||
|
Description
Adam Williamson
2007-12-18 23:01:53 UTC
Created attachment 13205 [details] [review] Patch to support Nokia 6300 as a music player Attaching a slightly changed version: it just puts x-mpeg at the top of the list of formats, so apps will default to using MP3 format for transcoding. With aac at the top, Rhythmbox defaults to using it, and it doesn't seem to work right, I think the Gstreamer AAC encoder is broken, so this is a workaround for now. Created attachment 13230 [details] [review] Patch to support Nokia 6300 as a music player updated to put mpeg at top of list I commit a adopted version of the patch to hal-info, but the output_formats of the entry can't contain audio/mpeg since this is set for all music player as default. If there are problems with Rhythmbox report it there, since the order of supported formats doesn't matter and are never guaranted by HAL. Every other assumption is clearly wrong! Well, when x-mpeg was low in the list, it tried to convert files to AAC and they wouldn't play on the phone. When I put it at the top of the list, it converted the files to MP3 and they played fine. I call that empirical evidence. *shrug* anyway, why is it in the list for all music players? there have been players that don't play MP3. older Sony flash players, for instance. (In reply to comment #5) > Well, when x-mpeg was low in the list, it tried to convert files to AAC and > they wouldn't play on the phone. When I put it at the top of the list, it > converted the files to MP3 and they played fine. I call that empirical > evidence. *shrug* Sorry, but this is _NOT_ a bug in HAL! As I already explained: This is the problem of the tools above HAL. There is no guaranted order of the supported formats in HAL (it's only: "A string list of MIME-types representing the kind of audio formats that the device can play back." and nothing more. No order, no priorities within the list!). File a bug against Rythmbox if there is a problem, but not against HAL! HAL isn't the source of the problem. > anyway, why is it in the list for all music players? there have been players > that don't play MP3. older Sony flash players, for instance. There is also a section for devices that don't support mp3, we are not that stupid ... I see, wasn't entirely sure what your original message meant, now I understand - RB is parsing the HAL file contents as a list in preferred order, but that's not how they're meant. Thanks. There's no need for such a defensive tone, no-one's attacking you. Commited adopted version. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.