Bug 13730 - Patch to support Nokia 6300 as a music device
Summary: Patch to support Nokia 6300 as a music device
Status: RESOLVED FIXED
Alias: None
Product: hal
Classification: Unclassified
Component: hal-info (show other bugs)
Version: unspecified
Hardware: All All
: medium enhancement
Assignee: Danny Kukawka
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-12-18 23:01 UTC by Adam Williamson
Modified: 2008-03-04 07:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to support Nokia 6300 as a music player (1.15 KB, patch)
2007-12-18 23:02 UTC, Adam Williamson
Details | Splinter Review
Patch to support Nokia 6300 as a music player (1.14 KB, patch)
2007-12-19 11:43 UTC, Adam Williamson
Details | Splinter Review

Description Adam Williamson 2007-12-18 23:01:53 UTC
The Nokia 6300 cellphone can act as a music player. It also has a USB mass storage transfer mode. The attached patch for 10-usb-music-players.fdi defines the correct file formats and folder to be able to use the phone as a music player when connected in mass storage mode. I have tested that with this patch applied, I can play music from the phone and transfer songs to the phone (having them transcoded where appropriate) using Rhythmbox.
Comment 1 Adam Williamson 2007-12-18 23:02:15 UTC
Created attachment 13205 [details] [review]
Patch to support Nokia 6300 as a music player
Comment 2 Adam Williamson 2007-12-19 11:43:21 UTC
Attaching a slightly changed version: it just puts x-mpeg at the top of the list of formats, so apps will default to using MP3 format for transcoding. With aac at the top, Rhythmbox defaults to using it, and it doesn't seem to work right, I think the Gstreamer AAC encoder is broken, so this is a workaround for now.
Comment 3 Adam Williamson 2007-12-19 11:43:55 UTC
Created attachment 13230 [details] [review]
Patch to support Nokia 6300 as a music player

updated to put mpeg at top of list
Comment 4 Danny Kukawka 2007-12-24 15:37:35 UTC
I commit a adopted version of the patch to hal-info, but the output_formats of the entry can't contain audio/mpeg since this is set for all music player as default.

If there are problems with Rhythmbox report it there, since the order of supported formats doesn't matter and are never guaranted by HAL. Every other assumption is clearly wrong! 
Comment 5 Adam Williamson 2007-12-24 17:29:07 UTC
Well, when x-mpeg was low in the list, it tried to convert files to AAC and they wouldn't play on the phone. When I put it at the top of the list, it converted the files to MP3 and they played fine. I call that empirical evidence. *shrug*

anyway, why is it in the list for all music players? there have been players that don't play MP3. older Sony flash players, for instance.
Comment 6 Danny Kukawka 2007-12-25 09:40:18 UTC
(In reply to comment #5)
> Well, when x-mpeg was low in the list, it tried to convert files to AAC and
> they wouldn't play on the phone. When I put it at the top of the list, it
> converted the files to MP3 and they played fine. I call that empirical
> evidence. *shrug*

Sorry, but this is _NOT_ a bug in HAL! As I already explained: This is the problem of the tools above HAL. There is no guaranted order of the supported formats in HAL (it's only: "A string list of MIME-types representing the kind of audio formats that the device can play back." and nothing more. No order, no priorities within the list!). File a bug against Rythmbox if there is a problem, but not against HAL! HAL isn't the source of the problem.

> anyway, why is it in the list for all music players? there have been players
> that don't play MP3. older Sony flash players, for instance.

There is also a section for devices that don't support mp3, we are not that stupid ... 

Comment 7 Adam Williamson 2007-12-25 23:08:32 UTC
I see, wasn't entirely sure what your original message meant, now I understand - RB is parsing the HAL file contents as a list in preferred order, but that's not how they're meant. Thanks.

There's no need for such a defensive tone, no-one's attacking you.
Comment 8 Danny Kukawka 2008-03-04 07:39:11 UTC
Commited adopted version.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.