Bug 15078

Summary:

xorg/app/xkbprint - Compile warning fixes

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

App/other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

janitor, patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-Compile-warning-fixes.patch	none
whitespace cleaned version of id=15207	none
fix some build problems	none

Description Paulo César Pereira de Andrade 2008-03-16 15:04:37 UTC

Created attachment 15207 [details] [review]
0001-Compile-warning-fixes.patch

Use constant octals instead of constant characters in switch case values
to avoid warnings/problems if constant characters are signed.
  Ansify some functions in utils.c.

Comment 1 Peter Breitenlohner 2008-11-14 05:22:27 UTC

Created attachment 20304 [details] [review]
whitespace cleaned version of id=15207

I think this patch (id=15207) should be applied, however preferably in this slightly modified version without whitespace warnings (space+tab)

Comment 2 Peter Breitenlohner 2008-11-14 05:27:38 UTC

Created attachment 20305 [details]
fix some build problems

This patch may be needed in addition

Comment 3 Paulo César Pereira de Andrade 2008-11-27 22:14:15 UTC

Thanks.

Applied as 58d940fbb303cc16549f913e33429362760132de
and 077871dce17f78ffa94e8bc2de21461fd8a4960d

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.