Bug 15078 - xorg/app/xkbprint - Compile warning fixes
Summary: xorg/app/xkbprint - Compile warning fixes
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: janitor, patch
Depends on:
Blocks:
 
Reported: 2008-03-16 15:04 UTC by Paulo César Pereira de Andrade
Modified: 2008-11-27 22:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-Compile-warning-fixes.patch (3.70 KB, patch)
2008-03-16 15:04 UTC, Paulo César Pereira de Andrade 		no flags Details | Splinter Review
whitespace cleaned version of id=15207 (3.75 KB, patch)
2008-11-14 05:22 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
fix some build problems (1.18 KB, application/octet-stream)
2008-11-14 05:27 UTC, Peter Breitenlohner 		no flags Details
Show Obsolete (1) View All

Description Paulo César Pereira de Andrade 2008-03-16 15:04:37 UTC 
Created attachment 15207 [details] [review]
0001-Compile-warning-fixes.patch

Use constant octals instead of constant characters in switch case values
to avoid warnings/problems if constant characters are signed.
  Ansify some functions in utils.c.
Comment 1 Peter Breitenlohner 2008-11-14 05:22:27 UTC 
Created attachment 20304 [details] [review]
whitespace cleaned version of id=15207

I think this patch (id=15207) should be applied, however preferably in this slightly modified version without whitespace warnings (space+tab)
Comment 2 Peter Breitenlohner 2008-11-14 05:27:38 UTC 
Created attachment 20305 [details]
fix some build problems

This patch may be needed in addition
Comment 3 Paulo César Pereira de Andrade 2008-11-27 22:14:15 UTC 
Thanks.

Applied as 58d940fbb303cc16549f913e33429362760132de
and 077871dce17f78ffa94e8bc2de21461fd8a4960d

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.