| Summary: | add 256x256 size to hicolor. | ||
|---|---|---|---|
| Product: | Specifications | Reporter: | Jakub Steiner <jimmac> |
| Component: | desktop-entry | Assignee: | Alexander Larsson <alexl> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | Amitbhati.webswastech, walch.martin |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
adds 256x256 size to the hicolor skeleton theme.
Those should actually be of type Scalable Final touch for better 256x256 support |
||
|
Description
Jakub Steiner
2008-03-27 14:09:25 UTC
Created attachment 15518 [details] [review] Those should actually be of type Scalable This didn't apply to cvs as it had some extra stock/emoticon that was not there. It also duplicated the 256x256 dirs in the Directories key. I fixed that and commited. *** Bug 21961 has been marked as a duplicate of this bug. *** There's one more thing that doesn't make this quite work -- You've changed the Type form Scalable to Threshold (and the threshold is the default of 2). This way the 256x256 icon is used only for target canvas 254px-258px if I'm not mistaken. My intention was that if the high-res icon exists, it should be used from 64px to 256px and be of Type=Scalable. And yea if it exists it takes precedence over scalable which never gets used. So I guess those 256x256 should be: Type=Scalable MinSize=64 MaxSize=256 Size=256 Hrm, also, I'd guess Makefile.in should create the directories. Oh, and, hrm, the patch added document and generic contexts for 256x256, but those contexts don't exist elsewhere. Created attachment 31745 [details] [review] Final touch for better 256x256 support This should fix everything mentioned in the bug -- creating the directories, removing the contexts that shouldn't be there and correct minsize/maxsize. *** Bug 25627 has been marked as a duplicate of this bug. *** pushed to master Also, i released 0.12 with this at: http://icon-theme.freedesktop.org/wiki/HicolorTheme |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.